1390282 - Allow RemotePageManager to accept an array of URLs

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Kate Hudson :k88hudson]

For Activity Stream, we need to be able to target messages from both about:newtab and about:home; it would be great if we could configure the RemotePageManager to listen to both.

Comment 1

[Adam Hillier :ahillier]

Attachment: Bug 1390282 - Allow RemotePageManager to accept an array of URLs

Review commit: https://reviewboard.mozilla.org/r/168750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168750/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8897454 [details]
Bug 1390282 - Allow RemotePageManager to accept an array of URLs

https://reviewboard.mozilla.org/r/168750/#review174084

I'd like to see some tests for this please.

::: toolkit/modules/RemotePageManager.jsm:67
(Diff revision 1)
> - * messages from all loaded pages from the requested url.
> + * messages from all loaded pages from the requested urls.
>   */
> -this.RemotePages = function(url) {
> -  this.url = url;
> +this.RemotePages = function(urls) {
> +  this.urls = Array.isArray(urls) ? urls : [urls];
> +  // In case anyone is still using .url property
> +  this.url = this.urls[0];

Do we have anyone in-tree using this? If not let's just remove it.

Comment 3

[Ed Lee :Mardak]

ahillier, what's the plan with having RemotePages take an array? Will AboutNewTab be updated to register both about:home and about:newtab? I suppose registering the existing about:home should effectively be a no-op as that page isn't listening for activity stream messages anyway.. ?

Comment 4

[Adam Hillier :ahillier]

Mardak: Yeah, with this patch and with AboutNewTab registering both pages, setting ActivityStream as the home page in AboutRedirector gives a build with a working ActivityStream home page.

Comment 5

[Adam Hillier :ahillier]

Comment on attachment 8897454 [details]
Bug 1390282 - Allow RemotePageManager to accept an array of URLs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168750/diff/1-2/

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8897454 [details]
Bug 1390282 - Allow RemotePageManager to accept an array of URLs

https://reviewboard.mozilla.org/r/168750/#review174248

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7eed04597d5e
Allow RemotePageManager to accept an array of URLs r=mossop

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7eed04597d5e