Closed Bug 1390471 Opened 7 years ago Closed 7 years ago

Remove xpcshell's environment object

Categories

(Core :: XPConnect, enhancement)

Product:
Core
Component:
XPConnect
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Patch
5.06 KB, patch
bholley
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review
I'm removing all getProperty/setProperty Class hooks in Gecko (bug 1389510) and xpcshell's environment object has env_setProperty. This environment object seems to be unused: I added a MOZ_CRASH in the resolve/enumerate/setProperty hooks and they don't hit on a Linux64 Try push.
Attachment #8897389 - Flags: review?(bobbyholley)
Attachment #8897389 - Flags: review?(bobbyholley) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9d4b16fa3dd7 Remove xpcshell's environment object. r=bholley
https://hg.mozilla.org/mozilla-central/rev/9d4b16fa3dd7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: