Remove xpcshell's environment object

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Created attachment 8897389 [details] [diff] [review]
Patch

I'm removing all getProperty/setProperty Class hooks in Gecko (bug 1389510) and xpcshell's environment object has env_setProperty.

This environment object seems to be unused: I added a MOZ_CRASH in the resolve/enumerate/setProperty hooks and they don't hit on a Linux64 Try push.
Attachment #8897389 - Flags: review?(bobbyholley)
Attachment #8897389 - Flags: review?(bobbyholley) → review+

Comment 1

a year ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d4b16fa3dd7
Remove xpcshell's environment object. r=bholley

Comment 2

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9d4b16fa3dd7
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.