Closed Bug 1390611 Opened 7 years ago Closed 4 years ago

Convert WebExtensions code to use Services.prefs instead of Preferences.jsm

Categories

(WebExtensions :: General, task, P5)

task

Tracking

(firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: mstriemer, Assigned: masterwayz)

Details

Attachments

(1 file)

We should prefer using Services.prefs over Preferences.jsm, but ext-pivacy is currently using Preferences.jsm. Let's convert that file over.
Extracted from bug 1345158 comment 31.
Files to convert include:

ext-privacy.js
ext-browserSettings.js
ExtensionPreferencesManager.jsm
Assignee: nobody → bob.silverberg
Summary: Covert ext-privacy to use Services.prefs instead of Preferences.jsm → Covert WebExtensions code to use Services.prefs instead of Preferences.jsm
There's a typo in the bug title ("Covert" when it should be "Convert")
No, this is a covert operation. Shhhh.

Just kidding, thanks for noticing.
Summary: Covert WebExtensions code to use Services.prefs instead of Preferences.jsm → Convert WebExtensions code to use Services.prefs instead of Preferences.jsm
Product: Toolkit → WebExtensions
Assignee: bob.silverberg → michael
Status: NEW → ASSIGNED

ext-browserSettings.js has already been converted, what remains is ExtensionPreferencesManager.jsm and ext-privacy.js.

ext-privacy.js is straightforward, ExtensionPreferencesManager uses the Preferences constructor, so that is a bit more involved than just replacing Preferences.get with Services.prefs.get.

Type: enhancement → task
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59a027d6beb5
Convert ext-privacy.js to use Services.prefs r=robwu
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: