1390611 - Convert WebExtensions code to use Services.prefs instead of Preferences.jsm

Status: RESOLVED FIXED

(WebExtensions :: General, task, P5)

Description

[Mark Striemer [:mstriemer]]

We should prefer using Services.prefs over Preferences.jsm, but ext-pivacy is currently using Preferences.jsm. Let's convert that file over.

Comment 1

[Mark Striemer [:mstriemer]]

Extracted from bug 1345158 comment 31.

Comment 2

[Bob Silverberg [:bsilverberg]]

Files to convert include:

ext-privacy.js
ext-browserSettings.js
ExtensionPreferencesManager.jsm

Comment 3

[Stephan Sokolow]

There's a typo in the bug title ("Covert" when it should be "Convert")

Comment 4

[Bob Silverberg [:bsilverberg]]

No, this is a covert operation. Shhhh.

Just kidding, thanks for noticing.

Comment 5

[Rob Wu [:robwu]]

ext-browserSettings.js has already been converted, what remains is ExtensionPreferencesManager.jsm and ext-privacy.js.

ext-privacy.js is straightforward, ExtensionPreferencesManager uses the Preferences constructor, so that is a bit more involved than just replacing Preferences.get with Services.prefs.get.

Comment 6

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1390611 - Convert ext-privacy.js to use Services.prefs r=robwu

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59a027d6beb5
Convert ext-privacy.js to use Services.prefs r=robwu

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/59a027d6beb5