Closed Bug 1390620 Opened 4 years ago Closed 4 years ago
Botched rebase: address (if needed) override
Scale Type and fit Center for Stream Page Icon Layout
59 bytes, text/x-review-board-request
In my rebase of bug 1301718, I needed to rebase over Sebastian's favicon changes that changed `overrideScaleType=false` and `scaleType=fitCenter` on the faviconView. However, I forgot to do the update during the rebase and now there's a TODO in the code. Verify it's actually a problem and fix it!
4 years ago
Priority: -- → P1
bug 1383736 was the bug that Sebastian made the favicon changes in and here's a link to the lines: https://hg.mozilla.org/mozilla-central/annotate/b95b1638db48fc3d450b95b98da6bcd2f9326d2f/mobile/android/app/src/main/res/layout/activity_stream_card_history_item.xml#l29
Depends on: 1383736
Note: all I landed was highlights changes so this should only affect the highlights icons.
Comment on attachment 8897559 [details] Bug 1390620: Set centerInside StreamPageIconLayout's FaviconView; add comments. https://reviewboard.mozilla.org/r/168832/#review175854
Attachment #8897559 - Flags: review?(s.kaspari) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ecc3f03e5eae Set centerInside StreamPageIconLayout's FaviconView; add comments. r=sebastian
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.