1390629 - Library window should disable most of the 'view' menu because it isn't functional in the library window

Status: RESOLVED DUPLICATE of bug 1402059

(Firefox :: Toolbars and Customization, defect, P3)

Description

[:Atoll]

On Nightly (2017-08-15) and OS X 10.12.6 (release), the Library window silently ignores any attempt to customize the toolbar using the menu item View -> Toolbars -> Customize...

Comment 1

[Jim Mathies [:jimm]]

Hey Tracy, can you attempt to repro and if you can post str. thanks.

Comment 2

[Tracy Walker [:tracy]]

Yes, this is easily reproducible.  However, the bug here is that the items under View are visible.  They should all be disabled (greyed out) except the Full Screen option.

STR:

1) open Library from Menu > History > Show all history (Menu > Bookmarks > Show all bookmarks)
2) From the Library, Select Menu > View

Tested results: all items of this menu are visible

Expected results:  All items of this menu should be disabled except the Enter Full Screen option.

Comment 3

[Jim Mathies [:jimm]]

Sounds serious, maybe this need to get prioritized into current work. Panos, any thoughts on what to do with this to get it in front of someone?

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Browser Console contains this:

ReferenceError: gBrowser is not defined[Learn More]  browser.js:4373:1
	updateCharacterEncodingMenuState chrome://browser/content/browser.js:4373:1
	onpopupshowing chrome://browser/content/places/places.xul:1:1
ReferenceError: gNavToolbox is not defined[Learn More]  browser.js:5381:7
	getTogglableToolbars chrome://browser/content/browser.js:5381:7
	onViewToolbarsPopupShowing chrome://browser/content/browser.js:5401:22
	onpopupshowing chrome://browser/content/places/places.xul:1:1
ReferenceError: gBrowser is not defined[Learn More]  browser.js:4373:1
	updateCharacterEncodingMenuState chrome://browser/content/browser.js:4373:1
	onpopupshowing chrome://browser/content/places/places.xul:1:1
ReferenceError: gCustomizeMode is not defined[Learn More]  places.xul:1:1
	oncommand chrome://browser/content/places/places.xul:1:1


However this is unlikely to get prioritized for 57 as things stand.

Comment 5

[:Gijs (he/him)]

This worked OK in 54.

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7ce557b85b611536b69539a7c18d4834ffc92eea&tochange=23d9d005d92afdb5afabeae2ad672323c7d903ad

My bet is bug 1381853. Florian, can you take a look?

Comment 7

[Florian Quèze [:florian]]

(In reply to :Gijs from comment #6)
> https://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=7ce557b85b611536b69539a7c18d4834ffc92eea&tochange=23d9
> d005d92afdb5afabeae2ad672323c7d903ad
> 
> My bet is bug 1381853. Florian, can you take a look?

Too late for 56 at this point, sorry I didn't get to this needinfo soon enough :-/. Mark has a fix for this in bug 1402059 so duping forward.