1390644 - Syncing… in devices list should say Syncing Tabs…

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P2)

Description

[Ryan Feeley [:rfeeley]]

"Sync Now" in Synced Tabs does not perform a full Sync but rather just refreshes the list of devices. It should therefore just say "Refresh Devices".

While refreshing it should say "Refreshing…" (and not "Syncing…")

The tooltip should not be prefixed with "Last sync:" but rather "Updated:"

Comment 1

[Ryan Feeley [:rfeeley]]

A correction to the above… After learning that this feature also syncs the currently opened tabs, we can take a much less radical approach.

The only change required is to change the mid-sync state of "Syncing…" to "Syncing Tabs…"

That provides just enough context for all users to understand that a full sync is not happening.

Comment 2

[meghasharma4910]

Hi, I am a beginner. Can I take it up? Also, it would be great if you could provide me with some starter points!

Comment 3

[Steve Armand]

Attachment: Change the mid-sync state of "Syncing…" to "Syncing Tabs…"

Comment 4

[Steve Armand]

Hi, I'm new as well. I'm submitting the attached patch as my first. Please advise on next steps!

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8901615 [details] [diff] [review]
Change the mid-sync state of "Syncing…" to "Syncing Tabs…"

Review of attachment 8901615 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, but due to how Firefox is localized, the string ID also needs to be changed. ie, sync.properties probably needs to change to something like:

syncingtabs.label = Syncing Tabs…

and all references in the code to |syncing2.label| need to change to |syncingtabs.label|

Could you please make these changes and re-upload the patch for review. Ideally, you can try to follow the dev guide and push the patch to mozreview. If you change the commit message to |Bug 1390644 - Change the mid-sync state of "Syncing…" to "Syncing Tabs…". r?eoger", then when you push to mozreview it will automatically ask Edouard for review and will simplify the process of pushing it once it is accepted. Let us know if you need help with any of that!

Comment 6

[Steve Armand]

Attachment: Bug 1390644 - Change the mid-sync state of "Syncing…" to "Syncing Tabs…".

Review commit: https://reviewboard.mozilla.org/r/173696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173696/

Comment 7

[Steve Armand]

Ok, I've made the recommended changes and pushed to mozreview.

Comment 8

[Edouard Oger [:eoger]]

Comment on attachment 8902217 [details]
Bug 1390644 - Change the mid-sync state of "Syncing…" to "Syncing Tabs…".

https://reviewboard.mozilla.org/r/173696/#review179114

Works great, thank you for your patch!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a87086e6552
Change the mid-sync state of "Syncing…" to "Syncing Tabs…". r=eoger

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3a87086e6552