1390675 - Preferences -> Site Data -> Settings cannot be closed with the Escape key

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[:Atoll]

Unlike many other "popup" windows in Preferences, the one popped up by Site Data -> Settings cannot be closed with the Escape key.

Nightly 8/15, OS X 10.12.6.

Comment 1

[:Gijs (out for now; he/him)]

Fischer, can you take a look? It's not clear to me off-hand why this wouldn't work for the site data dialog, but it should.

Comment 2

[Fischer [:Fischer]]

(In reply to :Gijs from comment #1)
> Fischer, can you take a look? It's not clear to me off-hand why this
> wouldn't work for the site data dialog, but it should.
OK, will look into this.

Comment 3

[Fischer [:Fischer]]

Attachment: Bug 1390675 - Preferences -> Site Data -> Settings cannot be closed with the Escape key,

Review commit: https://reviewboard.mozilla.org/r/170606/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170606/

Comment 4

[Fischer [:Fischer]]

(In reply to Fischer [:Fischer] from comment #3)
> Created attachment 8899370 [details]
> Bug 1390675 - Preferences -> Site Data -> Settings cannot be closed with the
> Escape key,
> 
> Review commit: https://reviewboard.mozilla.org/r/170606/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/170606/
Hi Gijs,

All we have to do is simply handle the ESC key, like what the permission subdialog did[1][2] and what the cookie subdialog did[3][4].

[1] http://searchfox.org/mozilla-central/rev/b258e6864ee3e809d40982bc5d0d5aff66a20780/browser/components/preferences/permissions.js#196
[2] http://searchfox.org/mozilla-central/rev/b258e6864ee3e809d40982bc5d0d5aff66a20780/browser/components/preferences/permissions.xul#20
[3] http://searchfox.org/mozilla-central/rev/b258e6864ee3e809d40982bc5d0d5aff66a20780/browser/components/preferences/cookies.js#934
[4] http://searchfox.org/mozilla-central/rev/b258e6864ee3e809d40982bc5d0d5aff66a20780/browser/components/preferences/cookies.xul#20

Thanks

Comment 5

[:Gijs (out for now; he/him)]

Comment on attachment 8899370 [details]
Bug 1390675 - Preferences -> Site Data -> Settings cannot be closed with the Escape key,

https://reviewboard.mozilla.org/r/170606/#review175782

I think we could get this for free (and also the buttons / button labels) if we used proper dialog markup, but we can leave that for some other time...

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c78673f78219
Preferences -> Site Data -> Settings cannot be closed with the Escape key, r=Gijs

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c78673f78219

Comment 8

[Md. Majedul islam]

I have reproduced this bug with Nightly 57.0a1 (2017-08-15) on Ubuntu 16.04, 64 bit!

The fix is now verified on Latest Nightly 57.0a1 .

Build ID 	20170824100243
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 9

[Md. Rahimul Islam]

I have successfully reproduced this bug with Nightly 57.0a1 (2017-08-15) (32-bit) on windows 10(32bit)

this bug is verified fix with  latest nightly 57.0a1 (2017-08-24) (32-bit)

Build ID: 20170824100243
Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday-20170823]

Comment 10

[Md. Majedul islam]

As per Comment 8 and Comment 9, I am marking this bug as verified fixed.