Closed Bug 1390675 Opened 7 years ago Closed 7 years ago

Preferences -> Site Data -> Settings cannot be closed with the Escape key

Categories

(Firefox :: Settings UI, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: Atoll, Assigned: Fischer)

References

Details

(Whiteboard: [storage-v1])

Attachments

(1 file)

Unlike many other "popup" windows in Preferences, the one popped up by Site Data -> Settings cannot be closed with the Escape key.

Nightly 8/15, OS X 10.12.6.
Fischer, can you take a look? It's not clear to me off-hand why this wouldn't work for the site data dialog, but it should.
Blocks: 1312351
Component: General → Preferences
Flags: needinfo?(fliu)
(In reply to :Gijs from comment #1)
> Fischer, can you take a look? It's not clear to me off-hand why this
> wouldn't work for the site data dialog, but it should.
OK, will look into this.
Assignee: nobody → fliu
Flags: needinfo?(fliu)
Priority: -- → P2
Whiteboard: [storage-v1]
Comment on attachment 8899370 [details]
Bug 1390675 - Preferences -> Site Data -> Settings cannot be closed with the Escape key,

https://reviewboard.mozilla.org/r/170606/#review175782

I think we could get this for free (and also the buttons / button labels) if we used proper dialog markup, but we can leave that for some other time...
Attachment #8899370 - Flags: review?(gijskruitbosch+bugs) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c78673f78219
Preferences -> Site Data -> Settings cannot be closed with the Escape key, r=Gijs
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c78673f78219
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I have reproduced this bug with Nightly 57.0a1 (2017-08-15) on Ubuntu 16.04, 64 bit!

The fix is now verified on Latest Nightly 57.0a1 .

Build ID 	20170824100243
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170823]
I have successfully reproduced this bug with Nightly 57.0a1 (2017-08-15) (32-bit) on windows 10(32bit)

this bug is verified fix with  latest nightly 57.0a1 (2017-08-24) (32-bit)

Build ID: 20170824100243
Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday-20170823]
As per Comment 8 and Comment 9, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: