1390686 - Tab overview of recently-used-tab-changing stays displayed after releasing ctrl+tab when a textarea or textfield on page was focused

Status: RESOLVED INVALID

(Core :: Widget: Gtk, defect)

Description

[clearmartin]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170811100700

Steps to reproduce:

1) Enable option "Ctrl+Tab cycles through tabs in recently used order"
2) Focus a textfield or textarea
3) Press Ctrl+Tab and release quickly (just in order to switch to another tab)


Actual results:

-> Tab overview stays open.


Expected results:

Tab overview should close when Ctrl+Tab buttons are released.

Comment 1

[clearmartin]

Additional info: This problem started since version 55. It is still happening in Nightly (57.0a1).

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

Thanks for the STR. I can reproduce this even on Firefox 50, the first version with this feature, but I didn't notice that before. It only started recently. Maybe it's caused by recent system library update?

Not reproducible on Mac.

Comment 4

[clearmartin]

I'm confirming, that this is caused by GTK+ 3.22.18 minor update (meaing with GTK 3.22.17 it works fine). Just tested that on my Arch Linux.

Now, question is how's this behaviour reportable to GTK+ community. Because with standard changing tabs by Ctrl+Tab (without tab overview) everything works fine. I'll try to report this and we'll see :).

Comment 5

[Kan-Ru Chen [:kanru] (UTC+9)]

https://git.gnome.org/browse/gtk+/log/?qt=range&q=3.22.17..3.22.18 is the list of changes between GTK 3.22.17 and 3.22.18

Maybe doing a bisection can find the cause more quickly. I suspect that our current code depends on some undocumented behavior that had been fixed in the new GTK release.

Comment 6

[Kan-Ru Chen [:kanru] (UTC+9)]

https://git.gnome.org/browse/gtk+/commit/?id=a86de5905c0946b09b4ea89c87c87bdd5e38033b

A quick bisection shows that this commit is the bad one. Who would have thought that supporting emoji would break the ctrl-tab?

:clearmartin if you are going to file a upstream bug please attach this info :)

Comment 7

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: tentative patch for GTK

Comment 8

[clearmartin]

Wow, good job finding the commit and even writing a patch. Thanks! All provided in upstream GTK+ bugreport:
https://bugzilla.gnome.org/show_bug.cgi?id=786594

Comment 9

[Kan-Ru Chen [:kanru] (UTC+9)]

Thanks for reporting here and providing a STR, which is the key to find the bug :-)