1390717 - Intermittent /fetch/api/response/response-stream-disturbed-3.html | application crashed [@ bool IsAboutToBeFinalizedInternal<JSObject>(JSObject**)]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=123302110&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/ZJhBA3esQJWa-dNWzJtioA/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Intermittent Failures Robot]

5 failures in 949 pushes (0.005 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 3
* mozilla-inbound: 2

Platform breakdown:
* osx-10-10: 4
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1390717&startday=2017-08-14&endday=2017-08-20&tree=all

Comment 2

[Jon Coppeard (:jonco)]

The problem here is that FetchStream needs to call HoldJSObjects or mReadableStream won't get traced.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Note, this feature is still disabled by default, so not sure the bug needs to be private.

Comment 6

[Andrea Marchesini [:baku]]

Attachment: stream2.patch

As discussed with Jon on IRC, the issue is that we have 2 JS::Heap<ReadableStreams>, the first one is in FetchBody, and the second one is in FetchStream, but we TRACE only the former one.

Comment 7

[Jon Coppeard (:jonco)]

(In reply to Ben Kelly [:bkelly] from comment #5)
I didn't realise that.  Unhiding.

Comment 8

[Jon Coppeard (:jonco)]

Comment on attachment 8903145 [details] [diff] [review]
stream2.patch

Review of attachment 8903145 [details] [diff] [review]:
-----------------------------------------------------------------

Great.  Thanks for fixing.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9fba89f65c3
FetchStream should not have an extra JS::Heap<ReadableStream>, r=jonco

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a9fba89f65c3

Comment 11

[Intermittent Failures Robot]

1 failures in 939 pushes (0.001 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* try: 1

Platform breakdown:
* linux64-qr: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1390717&startday=2017-08-28&endday=2017-09-03&tree=all