Closed Bug 1390773 Opened 6 years ago Closed 6 years ago

stylo: Move functions related to anonymous element to GeckoElement

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(2 files)

style: Move functions related to anonymous element to GeckoElement (Bug 1390773)
59 bytes, text/x-review-board-request
emilio
: review+
Details
Servo PR #18121
41 bytes, text/x-github-pull-request
Details | Review 
In servo/components/style/gecko/wrapper.rs, we have several helper functions for flags like NODE_IS_ANONYMOUS_ROOT, and they're scatter in different places. (Bug 1382102 added yet another one.) I'd like to move them all to GeckoElement.
Comment on attachment 8897763 [details]
style: Move functions related to anonymous element to GeckoElement (Bug 1390773)

https://reviewboard.mozilla.org/r/169070/#review174378

LGTM, thanks!
Attachment #8897763 - Flags: review?(emilio+bugs) → review+
Priority: -- → P3
Attached file Servo PR #18121 — 

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/2451b21968df
Status: ASSIGNED → RESOLVED
Closed: 6 years ago

          status-firefox57:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57

          You need to log in
          before you can comment on or make changes to this bug.