Closed Bug 1390789 Opened 7 years ago Closed 7 years ago

Upgrade Python to 2.7.13

Categories

(Cloud Services :: Operations: AMO, task)

Product:
Cloud Services
Component:
Operations: AMO
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: cgrebs, Assigned: pcristiano)

Details

AMO is currently running using python 2.7.5 which is ancient so from a security (and potential performance) point of view we should be running the latest version which is currently 2.7.13. This also helps later with a potential bump to python 3. AMO unittests are already running on 2.7.13. This needs to be updated /backported in `Dockerfile` and `Dockerfile.deploy`.
How important is this bug? why not anyone got assigned to this bug even though its up for 3monts how big a task is it... Will i be Working alone on this??
This bug is not too important although newer versions usually provide bugfixes or security fixes along the way. Since this issue is about the operations side of addons.mozilla.org it's best to let these open for ops :)
Python 2.7.14 is up-to-date now. :wezhou I somehow hope this can be a low-hanging-fruit to get an up-to-date Python 2 and get any potential performance, security and bug fixes. Python 2.7.5 is ancient. This only needs to happen in our Centos 7 docker image I think.
Flags: needinfo?(wezhou)
Assigned to Philip to have a look.
Assignee: nobody → pcristiano
Flags: needinfo?(wezhou)
It seems we can try to move to the Docker Python images at https://hub.docker.com/_/python/ if possible. This should give us a path to stay current on 2.7.x releases going forward, at the cost of some time now. Other alternatives: * Install a latter version of Python into the current image - This means either finding a repository or maintaining our own build of Python, or installing from source during build or a base image. These methods require more maintenance going forward that doesn't add value to this project. * Using Centos Python - This doesn't necessarily have any later version of Python installed. The `2.7.14-stretch-slim` version may be a good place to start for a base image. I don't think this needs to be done by someone from ops, but please include me in a review if someone gets to this before me. I may be able to start this soon but will need help testing the app once I get a PR in place to use a new base image.
Status: NEW → ASSIGNED
Started some work in https://github.com/mozilla/addons-server/pull/7363. It currently builds but the built image has not been tested. I still need to update the `Dockerfile.deploy` file as well with these changes.
https://github.com/mozilla/addons-server/pull/7440 is the current PR after the previous one was merged. This relies on some config changes from puppet that will configure uWSGI appropriately.
Merged and deployed to dev. Will make it to prod with the release train next week.
This has now be deployed! There is still an issue that appeared after moving to the new base image: https://github.com/mozilla/addons-server/issues/7518.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.