1390790 - Label ScrollFrameHelper::ScheduleSyntheticMouseMove

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

The timer callback of ScrollFrameHelper::ScheduleSyntheticMouseMove is shown up in the top unlabeled runnable list:
https://gist.github.com/bevis-tseng/12cf108f681467ca7d8f3088db4eb584

We want this to be labeled to gain more benefit from qDOM scheduling.

It seems that ScrollFrameHelper could access the corresponding nsIDocument via PresShell, so maybe we can set the event target of mScrollActivityTimer to mOuter->PresContext()->PresShell()->GetDocument()->EventTargetFor(TaskCategory::Other) to fix this.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Patch: Label ScrollFrameHelper::ScheduleSyntheticMouseMove.

Wait for the treeherder result to request the review:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9977490781eaaf593d15053ac3be05fdb61704b6

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Patch: Label ScrollFrameHelper::ScheduleSyntheticMouseMove.

(update: SetTarget() once after timer constructed.)

Treeherder result looks fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e3fd9c91b9d1cc740d972561a66353923707360&selectedJob=123528296

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc147ac0de39
Label ScrollFrameHelper::ScheduleSyntheticMouseMove. r=tnikkel

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cc147ac0de39