1390802 - Function storeValue implement error on mips64

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[yuyin]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/603.2.4 (KHTML, like Gecko) Version/10.1.1 Safari/603.2.4

Steps to reproduce:

run basic/spread-call-funapply.js with --tbpl


Actual results:

test failed


Expected results:

test pass

Comment 1

[yuyin]

when tag and store -1 (imm32).

mips64 store 0xfff8 8fff ffff ffff

tag: 0xfff88 

but it should store:

0xfff8 8000 ffff ffff

Comment 2

[yuyin]

Attachment: MIPS64-Fix-storeValue.patch

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Please attach a patch that includes commit information.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html#write-detailed-commit-messages

Comment 4

[yuyin]

Attachment: 0001-Bug-1390802-Fix-mips64-storeValue-function.patch

Comment 5

[yuyin]

thank you. attached.

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> Please attach a patch that includes commit information.
> http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/
> commits.html#write-detailed-commit-messages

Comment 6

[hev [:hev]]

Comment on attachment 8897795 [details] [diff] [review]
MIPS64-Fix-storeValue.patch

Review of attachment 8897795 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips64/MacroAssembler-mips64.cpp
@@ -1858,5 @@
>      MOZ_ASSERT(dest.base != SecondScratchReg);
>  
> -    ma_li(SecondScratchReg, ImmTag(JSVAL_TYPE_TO_TAG(type)));
> -    ma_dsll(SecondScratchReg, SecondScratchReg, Imm32(JSVAL_TAG_SHIFT));
> -    ma_dins(SecondScratchReg, reg, Imm32(0), Imm32(JSVAL_TAG_SHIFT));

ma_dins(SecondScratchReg, reg, Imm32(0), Imm32((type == JSVAL_TYPE_INT32) ? 32 : JSVAL_TAG_SHIFT));
What do you think?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8898102 [details] [diff] [review]
0001-Bug-1390802-Fix-mips64-storeValue-function.patch

Much better, thanks :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f192dae121a0
Fix mips64 storeValue function. r=luke

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f192dae121a0