Remove obsolete #back-button rule from compacttheme.inc.css

RESOLVED FIXED in Firefox 57

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: dex)

Tracking

(Blocks: 1 bug, {good-first-bug})

Trunk
Firefox 57
good-first-bug
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [reserve-photon-visual][good first bug][lang=css])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
#back-button already uses back.svg by default, so this rule isn't useful anymore:

http://searchfox.org/mozilla-central/rev/13148faaa91a1c823a7d68563d9995480e714979/browser/themes/shared/compacttheme.inc.css#139-142
Flags: qe-verify?
(Reporter)

Updated

2 years ago
Flags: qe-verify? → qe-verify-
(Assignee)

Comment 1

2 years ago
Hi, I'll like to work on this.
(Reporter)

Comment 2

2 years ago
Okay, let me know if you need help!
Assignee: nobody → dex
Status: NEW → ASSIGNED
Priority: P4 → P1
Comment hidden (mozreview-request)
(Reporter)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8898033 [details]
Bug 1390812 - Remove obsolete #back-button rule from compacttheme.inc.css

https://reviewboard.mozilla.org/r/169330/#review174800

Perfect, thanks!
Attachment #8898033 - Flags: review?(dao+bmo) → review+

Comment 5

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7b2bbce79b0
Remove obsolete #back-button rule from compacttheme.inc.css r=dao

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b7b2bbce79b0
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Iteration: --- → 57.2 - Aug 29
You need to log in before you can comment on or make changes to this bug.