1390857 - Aborted forced cast in SQLiteHistory.getModifiedHistory

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, enhancement, P1)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This crash popped up in Sentry for the 8.2 release:

https://sentry.prod.mozaws.net/share/issue/3235392e363339313830/

It is a forced cast that is failing. Possibly because one of those values is nil.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Unclear where this data is coming from, but marking as Sync anyway.

Comment 2

[Richard Newman [:rnewman]]

Stefan, where do you see any reference to getModifiedHistory in that stack? 

Did you paste the wrong crash report?

The crash you linked appears to be in:

    private func getConcernedIDs(colNames: [String]) -> ((SDRow) -> [String]) {
        return { (row: SDRow) in
             colNames.flatMap({ row[$0] as? String})
        }
    }

and that's a dynamic cast error, which doesn't make any sense with that `as?` there.

Comment 3

[Richard Newman [:rnewman]]

    fileprivate class func getPasswordOrigin(_ uriString: String, allowJS: Bool = false) -> String? {
        var realm: String? = nil
        if let uri = URL(string: uriString),
            let scheme = uri.scheme, !scheme.isEmpty {
            if allowJS && scheme == "javascript" {
                return "javascript:"
            }

            realm = "\(scheme)://\(uri.host!)"


Probably an empty host. This is called from LoginsHelper.swift, so while the data might have arrived from Sync, this seems to be just a plain ol' incorrect-assumptions bug.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Need info from Stefan on this one. As mentioned in Comment 2, the linked crash report doesn't match the bug description. The bug corresponding to the linked crash report has already been fixed in Bug 1384771:

https://github.com/mozilla-mobile/firefox-ios/commit/976444c20f0f26d5ccee5f713b20651c100202db

Comment 5

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Assuming these forced casts are the cause of the issue :st3fan was originally referencing, here's a patch.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8903814 [details] [review]
GitHub Pull Request

Carrying over R+ from GitHub

Comment 7

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/1c05391e0adab7169c16a355b83595bac71abfb4

Landed on v9.x:

https://github.com/mozilla-mobile/firefox-ios/commit/91b92c8cbadffd81c9561f95c26dc9a6f59b93ba