Closed Bug 1390868 Opened 8 years ago Closed 8 years ago

Crash in Login.getPasswordOrigin()

Categories

(Firefox for iOS :: General, enhancement, P1)

Other
iOS
enhancement

Tracking

()

RESOLVED FIXED
Iteration:
1.29
Tracking Status
fxios 9.0 ---

People

(Reporter: st3fan, Assigned: garvan)

References

Details

(Whiteboard: [Crash] [MobileCore])

Attachments

(1 file)

55 bytes, text/x-github-pull-request
jhugman
: review+
Details | Review
Unclear from the stack trace what this exactly is. Does the exception code tell us anything? Can we harden this code? Maybe do better input validation? Check all incoming values? https://sentry.prod.mozaws.net/share/issue/3235392e363339313837/
Priority: -- → P2
Whiteboard: [Crash] → [Crash] [MobileCore]
There are some forced casts in here that should be removed, will start with that
Assignee: nobody → gkeeley
Iteration: --- → 1.29
Priority: P2 → P1
Attached file Pull request
Attachment #8902387 - Flags: review?(jhugman)
Comment on attachment 8902387 [details] [review] Pull request LGTM, but comments requested.
Attachment #8902387 - Flags: review?(jhugman) → review+
Landed on master and uplifted to 9.x.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: