Closed Bug 1390935 Opened 7 years ago Closed 7 years ago

Review F* Curve25519 code in Hacl*

Categories

(NSS :: Libraries, enhancement)

Product:
NSS
Component:
Libraries
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: franziskus, Assigned: franziskus)

References

(
URL
)

Details

Tracking review of F* Curve25519 code in Hacl*.
https://nss-review.dev.mozaws.net/D414
Review comments are in https://nss-review.dev.mozaws.net/D414. This looks good to me.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Hi,

Is the review publically available somewhere? I'm asked for a login in https://nss-review.dev.mozaws.net/D414 but don't know if i have one.

Thanks!
Flags: needinfo?(franziskuskiefer)
The review should definitely be public. We switched phabricator instances recently and it looks like they changed things around. I'll ask around to get this public again.
<3
Chris, looks like some differentials are private and others aren't. I can't really tell why. Could you look into this? Maybe it's just this one that's made private.
Flags: needinfo?(franziskuskiefer) → needinfo?(ckolos)
The nss repo housed on that instance had been moved to User only access vs. public. I've made it public access again and can access the revision mentioned without logging in. Please try again and update.
Flags: needinfo?(ckolos)
Great, thanks Chris!
You need to log in before you can comment on or make changes to this bug.