Closed Bug 1390945 Opened 2 years ago Closed 2 years ago

Fix GCOV signal handlers to work in --disable-debug builds

Categories

(Testing :: Code Coverage, defect, critical)

Unspecified
Linux
defect
Not set
critical

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: decoder, Assigned: decoder)

References

Details

Attachments

(1 file)

Bug 1363469 added signal handlers for SIGUSR1 and SIGUSR2 that allow us to write out or reset coverage using these signals. Unfortunately the sigaction calls are wrapped on MOZ_ASSERT, causing them to not run in --disable-debug builds.

Patch follows shortly.
Comment on attachment 8897963 [details]
Bug 1390945 - Make GCOV signal handlers work in --disable-debug mode.

https://reviewboard.mozilla.org/r/169274/#review174970
Attachment #8897963 - Flags: review?(nfroyd) → review+
Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b7da7fee8e4
Make GCOV signal handlers work in --disable-debug mode. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/1b7da7fee8e4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.