1390964 - Cannot run mochitests if Firefox is built with a gcc that's not installed in the default prefix

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Botond Ballo [:botond]]

STR:
  1. Build gcc from source, and install it into a non-default prefix
     (that, is something other than '/usr').
  2. Build Firefox with the newly built gcc.
  3. Try to run a mochitest with |mach mochitest|.

Expected results:
  The mochitest runs.

Actual results:
  The mochitest run fails with errors of the form:

  <objdir>/dist/bin/xpcshell: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.21' not found

The problem is that programs built with such a gcc are linked to a libstdc++.so that's not in the linker's default search path, so the path containing the libstdc++.so needs to be added to LD_LIBRARY_PATH. However, the mochitest harness clobbers LD_LIBRARY_PATH [1].

[1] http://searchfox.org/mozilla-central/rev/13148faaa91a1c823a7d68563d9995480e714979/testing/mochitest/runtests.py#420

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1390964 - Do not clobber an existing LD_LIBRARY_PATH in the mochitest harness.

Review commit: https://reviewboard.mozilla.org/r/169214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169214/

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8897931 [details]
Bug 1390964 - Do not clobber an existing LD_LIBRARY_PATH in the mochitest harness.

https://reviewboard.mozilla.org/r/169214/#review178706

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa04de352d99
Do not clobber an existing LD_LIBRARY_PATH in the mochitest harness. r=ted

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for linting failure at gecko/testing/mochitest/runtests.py:420: test for membership should be 'not in':

https://hg.mozilla.org/integration/autoland/rev/b09836adb5f9fd2ac019f7ed7a660a367f404a25

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fa04de352d99f71042af8cc6cadcaa6bd1cf57f2&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=success
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=126517489&repo=autoland
> TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/mochitest/runtests.py:420:12 | test for membership should be 'not in' (E713)

Comment 5

[Botond Ballo [:botond]]

Comment on attachment 8897931 [details]
Bug 1390964 - Do not clobber an existing LD_LIBRARY_PATH in the mochitest harness.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169214/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e7d48fa2052
Do not clobber an existing LD_LIBRARY_PATH in the mochitest harness. r=ted

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6e7d48fa2052