Closed Bug 1390983 Opened 3 years ago Closed 3 years ago

We should error out of a 'by-foo-thing:' is used with the only choice as 'default'

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla57

People

(Reporter: Callek, Assigned: Callek)

Details

Attachments

(2 files)

Using by-foo-thing in the taskgraph is useful, but having by-foo-thing with only one choice of default just proceeds to add confusion.

There are valid use cases for by-foo-thing with only one option though (e.g. other options are invalid).

This patch set resolves current cases of 'by-foo-thing: default: bar' and creates an error related to it.
Comment on attachment 8897946 [details]
Bug 1390983 - Rip out 'by-X: default: ..' when it is the only choice present.

https://reviewboard.mozilla.org/r/169244/#review174950
Attachment #8897946 - Flags: review?(dustin) → review+
Comment on attachment 8897947 [details]
Bug 1390983 - Keyed-by default shouldn't be the only item, error out if it is.

https://reviewboard.mozilla.org/r/169246/#review174952

I like this, and it eliminated a bunch of cruft!
Attachment #8897947 - Flags: review?(dustin) → review+
Pushed by Callek@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a2eeb1ef90a3
Rip out 'by-X: default: ..' when it is the only choice present. r=dustin
https://hg.mozilla.org/integration/autoland/rev/c1f34cab5afc
Keyed-by default shouldn't be the only item, error out if it is. r=dustin
https://hg.mozilla.org/mozilla-central/rev/a2eeb1ef90a3
https://hg.mozilla.org/mozilla-central/rev/c1f34cab5afc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.