1390983 - We should error out of a 'by-foo-thing:' is used with the only choice as 'default'

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Justin Wood (:Callek)]

Using by-foo-thing in the taskgraph is useful, but having by-foo-thing with only one choice of default just proceeds to add confusion.

There are valid use cases for by-foo-thing with only one option though (e.g. other options are invalid).

This patch set resolves current cases of 'by-foo-thing: default: bar' and creates an error related to it.

Comment 1

[Justin Wood (:Callek)]

Attachment: Bug 1390983 - Rip out 'by-X: default: ..' when it is the only choice present.

Review commit: https://reviewboard.mozilla.org/r/169244/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169244/

Comment 2

[Justin Wood (:Callek)]

Attachment: Bug 1390983 - Keyed-by default shouldn't be the only item, error out if it is.

Review commit: https://reviewboard.mozilla.org/r/169246/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169246/

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8897946 [details]
Bug 1390983 - Rip out 'by-X: default: ..' when it is the only choice present.

https://reviewboard.mozilla.org/r/169244/#review174950

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8897947 [details]
Bug 1390983 - Keyed-by default shouldn't be the only item, error out if it is.

https://reviewboard.mozilla.org/r/169246/#review174952

I like this, and it eliminated a bunch of cruft!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2eeb1ef90a3
Rip out 'by-X: default: ..' when it is the only choice present. r=dustin
https://hg.mozilla.org/integration/autoland/rev/c1f34cab5afc
Keyed-by default shouldn't be the only item, error out if it is. r=dustin

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a2eeb1ef90a3
https://hg.mozilla.org/mozilla-central/rev/c1f34cab5afc