1391016 - Only check "proxyAutoconfigUrl" if proxyType is set to "pac"

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Currently we always check the "proxyAutoconfigUrl" key even with the proxyType set to something else or completely missing. 

It should only be checked/used when "pac" is set as proxyType.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1391016 - Make sure that proxyType is required and a string.

The webdriver spec declares the "proxyType" as required, and of
type string.

Review commit: https://reviewboard.mozilla.org/r/169288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169288/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1391016 - "proxyAutoconfigUrl" is required for proxyType "pac".

Review commit: https://reviewboard.mozilla.org/r/169290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169290/

Comment 3

[David Burns :automatedtester]

Comment on attachment 8897987 [details]
Bug 1391016 - Make sure that proxyType is required and a string.

https://reviewboard.mozilla.org/r/169288/#review174660

Comment 4

[David Burns :automatedtester]

Comment on attachment 8897988 [details]
Bug 1391016 - "proxyAutoconfigUrl" is required for proxyType "pac".

https://reviewboard.mozilla.org/r/169290/#review174666

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8897988 [details]
Bug 1391016 - "proxyAutoconfigUrl" is required for proxyType "pac".

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169290/diff/1-2/

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I had to push a minor update to fix an eslint failure in session.js.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2222b1931d36
Make sure that proxyType is required and a string. r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/ebc619b0d656
"proxyAutoconfigUrl" is required for proxyType "pac". r=automatedtester

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2222b1931d36
https://hg.mozilla.org/mozilla-central/rev/ebc619b0d656