Closed Bug 1391101 Opened 8 years ago Closed 7 years ago

Permanent false-positive variable-first-line.html,variable-first-letter.html | application crashed [@ nsRuleNode::WalkRuleTree]

Categories

(Core :: CSS Parsing and Computation, defect, P5)

Product:
Core
Component:
CSS Parsing and Computation
Version:
57 Branch
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- affected
firefox58 --- affected

People

(Reporter: intermittent-bug-filer, Unassigned)

Details

(Keywords: assertion, crash, intermittent-failure, Whiteboard: [stockwell unknown])

Crash Data

Summary: Intermittent /css/css-variables-1/variable-first-line.html | application crashed [@ nsRuleNode::WalkRuleTree] → Permanent false-positive /css/css-variables-1/variable-first-line.html | application crashed [@ nsRuleNode::WalkRuleTree]
Summary: Permanent false-positive /css/css-variables-1/variable-first-line.html | application crashed [@ nsRuleNode::WalkRuleTree] → Permanent false-positive variable-first-line.html,variable-first-letter.html | application crashed [@ nsRuleNode::WalkRuleTree]
Also hits this assertion: Assertion failure: ruleData.mConditions.CacheableWithoutDependencies() || ((HasAnimationData() || GetLevel() == SheetType::Transition) && aContext->GetParent() && aContext->GetParent()->HasPseudoElementData()) (should only be uncacheable if we had an animation rule and we're inside a pseudo), at layout/style/nsRuleNode.cpp:2734 This only affects stylo-disabled builds, so maybe we don't care. On the other hand, false positives add noise to the logs, so if there's an easy fix here, it would be nice to get it taken care of. Can you please take a look, Hiro?
status-firefox56: --- → unaffected
status-firefox57: --- → affected
status-firefox58: --- → affected
status-firefox-esr52: --- → unaffected
Component: web-platform-tests → DOM: Animation
Flags: needinfo?(hikezoe)
Keywords: assertion
Product: Testing → Core
Version: Version 3 → 57 Branch
This is not animation case, it's actually first-letter or first-line. I did just take a look but I have no idea what's going on there. The assertion might be missing the first-letter/line cases, I am not sure though. Also I suspect this failure started from bug 1324618. Anyway I am afraid I can't make any easy fixes for this. CCing Cameron just in case.
Component: DOM: Animation → CSS Parsing and Computation
Flags: needinfo?(hikezoe)
In the last 7 days there were 33 failure. All the failures occur on Linux (Linux64,linux32 ).The build type on which the failures occur are debug and opt. Test suite: debug-web-platform-tests-e10s and mochitest-browser-chrome-e10s. This is an example of a recent log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=140633640&line Here is a part of the log: [task 2017-10-30T07:03:00.661Z] 07:03:00 INFO - mozcrash Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/tmpWQypX_.mozrunner/minidumps/6b6f46a5-b2cb-7cf8-dc2b-6c57b1cc5409.dmp /tmp/tmpI2q1A_ 5663 [task 2017-10-30T07:03:08.579Z] 07:03:08 INFO - mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/6b6f46a5-b2cb-7cf8-dc2b-6c57b1cc5409.dmp 5664 [task 2017-10-30T07:03:08.580Z] 07:03:08 INFO - mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/6b6f46a5-b2cb-7cf8-dc2b-6c57b1cc5409.extra 5665 [task 2017-10-30T07:03:08.609Z] 07:03:08 INFO - PROCESS-CRASH | /css/css-variables-1/variable-first-letter.html | application crashed [@ nsRuleNode::WalkRuleTree] 5666 [task 2017-10-30T07:03:08.610Z] 07:03:08 INFO - Crash dump filename: /tmp/tmpWQypX_.mozrunner/minidumps/6b6f46a5-b2cb-7cf8-dc2b-6c57b1cc5409.dmp 5667 [task 2017-10-30T07:03:08.610Z] 07:03:08 INFO - Operating system: Linux 5668 [task 2017-10-30T07:03:08.611Z] 07:03:08 INFO - 0.0.0 Linux 3.13.0-112-generic #159-Ubuntu SMP Fri Mar 3 15:26:07 UTC 2017 x86_64 5669 [task 2017-10-30T07:03:08.611Z] 07:03:08 INFO - CPU: x86 5670 [task 2017-10-30T07:03:08.611Z] 07:03:08 INFO - GenuineIntel family 6 model 62 stepping 4 5671 [task 2017-10-30T07:03:08.611Z] 07:03:08 INFO - 4 CPUs 5672 [task 2017-10-30T07:03:08.612Z] 07:03:08 INFO - 5673 [task 2017-10-30T07:03:08.612Z] 07:03:08 INFO - GPU: UNKNOWN 5674 [task 2017-10-30T07:03:08.612Z] 07:03:08 INFO - 5675 [task 2017-10-30T07:03:08.613Z] 07:03:08 INFO - Crash reason: SIGSEGV 5676 [task 2017-10-30T07:03:08.613Z] 07:03:08 INFO - Crash address: 0x0 5677 [task 2017-10-30T07:03:08.613Z] 07:03:08 INFO - Process uptime: not available 5678 [task 2017-10-30T07:03:08.614Z] 07:03:08 INFO - 5679 [task 2017-10-30T07:03:08.614Z] 07:03:08 INFO - Thread 0 (crashed) 5680 [task 2017-10-30T07:03:08.615Z] 07:03:08 INFO - 0 libxul.so!nsRuleNode::WalkRuleTree [nsRuleNode.cpp:d7a53e1454ad : 2700 + 0x16] 5681 [task 2017-10-30T07:03:08.615Z] 07:03:08 INFO - eip = 0xf15a2254 esp = 0xffd271a0 ebp = 0xffd27418 ebx = 0xf5467000 5682 [task 2017-10-30T07:03:08.615Z] 07:03:08 INFO - esi = 0x00000000 edi = 0xe0ad1010 eax = 0x00000000 ecx = 0xf74c1864 5683 [task 2017-10-30T07:03:08.616Z] 07:03:08 INFO - edx = 0x00000000 efl = 0x00210286 5684 [task 2017-10-30T07:03:08.616Z] 07:03:08 INFO - Found by: given as instruction pointer in context :jet Could you please take a look?
Flags: needinfo?(bugs)
Whiteboard: [stockwell needswork]
The need for the stylo-disabled test configuration will end in about ~30 days if all goes as planned, perhaps a bit longer if we hit any delays. At this point, we don't intend to fix these bugs and are concentrating our effort to finish the job of getting Stylo everywhere. Thx!
Flags: needinfo?(bugs)
as a note, I think we were going to leave stylo-disabled on 1 platform for 1 more release cycle- that would probably be linux64 which would still see failures here- I would prefer we move forward and commit to it after release and only test stylo builds:) I think in 2 weeks we can start having a more detailed discussion about what we should be running assuming all continues to go well.
The other option would be skipping this test on non-stylo instead of annotating it as an expected crash. If we don't intend to fix the underlying crash, I'd prefer that option so we at least get rid of the log spam and avoid confusion.
nsRuleNode is gone so it's not worth tracking these signatures anymore. Please file new bugs as appropriate.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.