1391126 - toolkit/components/backgroundhangmonitor/HangStack.cpp:2:10: fatal error: shared-libraries.h: No such file or directory

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Jan Beich]

On Tier3 platforms without GeckoProfiler (iOS, Linux non-x86, BSDs, Solaris) the build is broken due to usage of implementation-specific header. Until bug 1371159 is fixed to reproduce on Tier1 platforms one has to add `return None` to gecko_profiler() in toolkit/moz.configure.

In file included from objdir/toolkit/components/backgroundhangmonitor/Unified_cpp_ackgroundhangmonitor0.cpp:20:
toolkit/components/backgroundhangmonitor/HangStack.cpp:2:10: fatal error:
      'shared-libraries.h' file not found
#include "shared-libraries.h"
         ^~~~~~~~~~~~~~~~~~~~
1 error generated.

http://searchfox.org/mozilla-central/rev/5ce320a16f69/tools/profiler/moz.build#16
http://searchfox.org/mozilla-central/rev/5ce320a16f69/toolkit/moz.configure#26

Comment 1

[Jan Beich]

Note, reproducing on Try maybe shadowed by bug 1378312 and bug 1384423.

Comment 2

[Marco Perez [:mpk]]

Jan, is there a way to make the build succeed anyway on the affected platforms?
If it's by adding 'return None' to to gecko_profiler() in toolkit/moz.configure then I have failed to find the right spot.
Any help (even a temporary band-aid patch) would be greatly appreciated.

Comment 3

[Landry Breuil (:gaston)]

I'd also welcome a real fix commited before the next branch merge, otherwise we'll have to fix this in beta.

Comment 4

[Landry Breuil (:gaston)]

By 'return None' do you mean changing gecko_profiler() ? 

To me :

    if target.os == 'Android':
        return target.cpu in ('aarch64', 'arm', 'x86')
    elif target.kernel == 'Linux':
        return target.cpu in ('x86', 'x86_64')
    return target.os in ('OSX', 'WINNT')

On BSDs, this should already return None (or false)?

Comment 5

[Landry Breuil (:gaston)]

Aaah now i get it, it was 'to reproduce on tier1 you need to add return None' - sorry, not enough coffee. Clearing ni?

Comment 6

[Landry Breuil (:gaston)]

mystor, since that's your implem of bug 1367406 that caused the regression, any idea which way to fix this ?

Comment 7

[Nika Layzell [:nika] (ni? for response)]

(In reply to Landry Breuil (:gaston) from comment #6)
> mystor, since that's your implem of bug 1367406 that caused the regression,
> any idea which way to fix this ?

The imports from shared-libraries.h in that file should only be used in the HangStack::ReadModuleInformation method. Perhaps guard that function's implementation and the shared-libraries.h header in a `#ifdef MOZ_GECKO_PROFILER` (which I believe corresponds to the header being implemented) block? It's OK for that function to be a no-op on unsupported platforms.

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Attachment: Guard use of shared-libraries.h in HangStack.cpp behind MOZ_GECKO_PROFILER

I think this should work, although I don't have a convenient non-tier-1 platform to build on.

Comment 9

[Nathan Froyd [:froydnj]]

Comment on attachment 8908122 [details] [diff] [review]
Guard use of shared-libraries.h in HangStack.cpp behind MOZ_GECKO_PROFILER

Review of attachment 8908122 [details] [diff] [review]:
-----------------------------------------------------------------

If this works for Jan (or anybody else who wants to try it), it works for me.

Comment 10

[Landry Breuil (:gaston)]

Comment on attachment 8908122 [details] [diff] [review]
Guard use of shared-libraries.h in HangStack.cpp behind MOZ_GECKO_PROFILER

Definitely helps here, i'm at the linking libxul step with that diff.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bad8adc4d1de
Guard use of shared-libraries.h in HangStack.cpp behind MOZ_GECKO_PROFILER, r=froydnj

Comment 12

[Dan Horák]

I'm giving it a try on Fedora/ppc64le ...

Comment 13

[Dan Horák]

(In reply to Dan Horák from comment #12)
> I'm giving it a try on Fedora/ppc64le ...

libxul.so got created, so this issue is fixed, it failed later due another issue, I'll file a separate report for it

Comment 14

[Jan Beich]

Comment on attachment 8908122 [details] [diff] [review]
Guard use of shared-libraries.h in HangStack.cpp behind MOZ_GECKO_PROFILER

inbound + autoland merged locally builds fine without patches. Thank you!

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bad8adc4d1de

Comment 16

[Landry Breuil (:gaston)]

And it went in right before the m-c -> m-b merge, so no need to request uplift \o/