1391140 - reference count leak in CERT_NewTempCertificate

Status: RESOLVED INVALID

(NSS :: Libraries, enhancement)

Description

[Chris Newman]

The function CERT_NewTempCertificate in stanpcertdb.c has a reference count leak if the certificate is already cached.

If this call:
        c = NSSCryptoContext_FindCertificateByEncodedCertificate(gCC,
                                                                 &encoding);

returns a certificate, it will increment the reference count. A bit later in the code, there's a call to:
                cc = STAN_GetCERTCertificateOrRelease(c);

which also increments the reference count. Moving the call to:
                nssCertificate_Destroy(c);
so it's after the end of the conditional should resolve the reference count leak.

I'll try to produce a patch tomorrow.

Comment 1

[Chris Newman]

Sorry, I misdiagnosed the reference count leak I was tracking. Will open new correct bug if appropriate.