Closed
Bug 1391149
Opened 7 years ago
Closed 7 years ago
[Form Autofill] The hint message always shows "Also autofills name" even no name-related fields saved in storage
Categories
(Toolkit :: Form Manager, defect, P3)
Toolkit
Form Manager
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: lchang, Assigned: lchang)
References
Details
(Whiteboard: [form autofill:M3])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
steveck
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
It's caused because the computed fields always present in a profile even their value is empty. We can fix it by not exposing those empty properties. It also aligns with non-computed fields.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8898107 [details] Bug 1391149 - [Form Autofill] Avoid exposing fields with empty value from the storage. https://reviewboard.mozilla.org/r/169436/#review174832 LGTM, thanks!
Attachment #8898107 -
Flags: review?(schung) → review+
Pushed by lchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/60779dbe5083 [Form Autofill] Avoid exposing fields with empty value from the storage. r=steveck
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/60779dbe5083
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee | ||
Updated•7 years ago
|
status-firefox56:
--- → affected
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8898107 [details] Bug 1391149 - [Form Autofill] Avoid exposing fields with empty value from the storage. Approval Request Comment [Feature/Bug causing the regression]: It's regression caused by bug 1368008. [User impact if declined]: The hint message won't be accurate. [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: N/A [Is the change risky?]: No. [Why is the change risky/not risky?]: Changes only affect the Form Autofill storage and it just avoids exposing some empty value. [String changes made/needed]: N/A
Attachment #8898107 -
Flags: approval-mozilla-beta?
Comment 6•7 years ago
|
||
Comment on attachment 8898107 [details] Bug 1391149 - [Form Autofill] Avoid exposing fields with empty value from the storage. Fix a regression caused by bug 1368008. Beta56+.
Attachment #8898107 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in
before you can comment on or make changes to this bug.
Description
•