1391149 - [Form Autofill] The hint message always shows "Also autofills name" even no name-related fields saved in storage

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[Luke Chang [:lchang] (inactive)]

It's caused because the computed fields always present in a profile even their value is empty. We can fix it by not exposing those empty properties. It also aligns with non-computed fields.

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Bug 1391149 - [Form Autofill] Avoid exposing fields with empty value from the storage.

Review commit: https://reviewboard.mozilla.org/r/169436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169436/

Comment 2

[Steve Chung [:steveck]]

Comment on attachment 8898107 [details]
Bug 1391149 - [Form Autofill] Avoid exposing fields with empty value from the storage.

https://reviewboard.mozilla.org/r/169436/#review174832

LGTM, thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60779dbe5083
[Form Autofill] Avoid exposing fields with empty value from the storage. r=steveck

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/60779dbe5083

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8898107 [details]
Bug 1391149 - [Form Autofill] Avoid exposing fields with empty value from the storage.

Approval Request Comment
[Feature/Bug causing the regression]:
It's regression caused by bug 1368008.

[User impact if declined]:
The hint message won't be accurate.

[Is this code covered by automated tests?]:
Yes.

[Has the fix been verified in Nightly?]:
Yes.

[Needs manual test from QE? If yes, steps to reproduce]: 
No.

[List of other uplifts needed for the feature/fix]:
N/A

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
Changes only affect the Form Autofill storage and it just avoids exposing some empty value.

[String changes made/needed]:
N/A

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8898107 [details]
Bug 1391149 - [Form Autofill] Avoid exposing fields with empty value from the storage.

Fix a regression caused by bug 1368008. Beta56+.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/1c08a2f4d2fc14e2a88915a2bd8f033f04c058ab