1391160 - (photon) Status bar icons are invisible after back from fullscreen mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jing-wei Wu [:jwu]]

Steps to reproduce:
1. Use Nightly to browse "https://davidwalsh.name/demo/fullscreen.php".
2. Press "Launch Fullscreen", the status bar is hidden.
3. Press "Hide Fullscreen", the status bar is shown again.

Expected result:
The icons in status bar are visible as usual.

Actual result:
The icons in status bar become invisible.

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: invisible status bar icons

Comment 2

[Jing-wei Wu [:jwu]]

Attachment: Bug 1391160 - Remember SYSTEM_UI_FLAG_LIGHT_STATUS_BAR when show/hide fullscreen.

Keep the value of SYSTEM_UI_FLAG_LIGHT_STATUS_BAR in window system ui status when show/hide fullscreen.

Review commit: https://reviewboard.mozilla.org/r/169514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169514/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8898154 [details]
Bug 1391160 - Remember SYSTEM_UI_FLAG_LIGHT_STATUS_BAR when show/hide fullscreen.

https://reviewboard.mozilla.org/r/169514/#review174846

Comment 4

[Julian Chu [:walkingice]]

Comment on attachment 8898154 [details]
Bug 1391160 - Remember SYSTEM_UI_FLAG_LIGHT_STATUS_BAR when show/hide fullscreen.

https://reviewboard.mozilla.org/r/169514/#review175302

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8898154 [details]
Bug 1391160 - Remember SYSTEM_UI_FLAG_LIGHT_STATUS_BAR when show/hide fullscreen.

https://reviewboard.mozilla.org/r/169514/#review175856

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/ActivityUtils.java:42
(Diff revision 1)
>                  }
>              } else {
>                  newVis = View.SYSTEM_UI_FLAG_VISIBLE;
>              }
>  
> +            if (Build.VERSION.SDK_INT >= 23) {

See constants in AppConstants.

Comment 6

[Jing-wei Wu [:jwu]]

Comment on attachment 8898154 [details]
Bug 1391160 - Remember SYSTEM_UI_FLAG_LIGHT_STATUS_BAR when show/hide fullscreen.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169514/diff/1-2/

Comment 7

[Jing-wei Wu [:jwu]]

Just for reference, I use link https://davidwalsh.name/demo/fullscreen.php to test fullscreen show/hide.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21cb52d98f1c
Remember SYSTEM_UI_FLAG_LIGHT_STATUS_BAR when show/hide fullscreen. r=nechen,sebastian,walkingice

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/21cb52d98f1c

Comment 10

[Oana Horvath [:ohorvath]]

Still reproducing on Nightly 57 (2017-08-25).
Devices:
Oneplus Two (Android 6.0.1)
Motorola Nexus 6 (Android 7.0)

Comment 11

[Jing-wei Wu [:jwu]]

Looks like our code has been mis-merged because bug 1126479 was also editing 'ActivityUtils.java' at same time. We would send another patch to fix this issue later.

Comment 12

[Jing-wei Wu [:jwu]]

Comment on attachment 8898154 [details]
Bug 1391160 - Remember SYSTEM_UI_FLAG_LIGHT_STATUS_BAR when show/hide fullscreen.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169514/diff/2-3/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed62367e3c70
Remember SYSTEM_UI_FLAG_LIGHT_STATUS_BAR when show/hide fullscreen. r=nechen,sebastian,walkingice

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ed62367e3c70

Comment 15

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 57 (2017-08-30).
Devices:
Oneplus Two (Android 6.0.1)
HTC Desire 820 (Android 6.0.1)
Google Pixel (Android 7.1.2)