1391168 - Tab mutedInfo uses URL UUID rather than internal ID

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect, P2)

Description

[Lee Bousfield]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170810100255

Steps to reproduce:

Create a webextension (or use the debugger of an existing webextension) to run the following code:

chrome.tabs.create({}, x => {chrome.tabs.update(x.id, {muted:true});console.log(chrome.tabs.get(x.id, y => console.log(y.mutedInfo.extensionId)))})

In short, the code creates a tab, mutes it, then logs `tab.mutedInfo.extensionId`.


Actual results:

The extension's internal UUID was logged.


Expected results:

The extension's ID, as specified by chrome.runtime.id or browser.runtime.id, should have been logged.

Comment 1

[Kris Maglione [:kmag]]

This is intentional.

Comment 2

[Lee Bousfield]

In Chrome, the ID outputted is the same as chrome.browser.id. At the least, this is an incompatibility with the chrome API. Can I ask why this design decision was made? Maybe privacy? In my use case, I'd like to check if my extension muted the tab. I figure this is a primary use case for `mutedInfo.extensionId`. However, I don't see a good way to get the internal UUID with the current API (the best I can do is `browser.i18n.getMessage("@@extension_id")`).

Comment 3

[Kris Maglione [:kmag]]

Ah, I see what you're saying now.

Comment 4

[Lee Bousfield]

Attachment: Use extension ID instead of URL UUID for tab.mutedInfo (bug 1391168)

Review commit: https://reviewboard.mozilla.org/r/169992/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169992/

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8898601 [details]
Use extension ID instead of URL UUID for tab.mutedInfo (bug 1391168)

https://reviewboard.mozilla.org/r/169992/#review178138

Thanks, and sorry for the delay!

Comment 6

[Andy McKay]

Once you've got r+ on a bug, like this, you need to add checkin-needed to the keywords, a sheriff will come a long and try to commit it for you. I've done this on your behalf so we can get this landed. Thanks for your patch!

Comment 7

[Lee Bousfield]

Okay. It's worth noting that I did get a try build, but it looks like it failed due to an unrelated build system issue: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ef17167ed7d

Comment 8

[Kris Maglione [:kmag]]

(In reply to ljbousfield from comment #7)
> Okay. It's worth noting that I did get a try build, but it looks like it
> failed due to an unrelated build system issue:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ef17167ed7d

It looks like there was an infrastructure failure. I triggered a new try run.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dac54fb0d76
Use extension ID instead of URL UUID for tab.mutedInfo r=kmag

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5dac54fb0d76

Comment 11

[Caitlin Neiman [:caitmuenster]]

Thanks so much, ljbousfield! Welcome onboard. Your contribution has been added to our recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition#September_2017

If you'd like to create a profile on mozillians.org, I'd be happy to vouch for you.