MIPS32: Port unimplemented parts of Bug 1364908

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36
(Assignee)

Comment 1

2 years ago
Moved form bug 1329650.
Implements missing parts from bug 1364908 "Move moveValue into the generic MacroAssembler" on mips32.
Attachment #8898197 - Flags: review?(bbouvier)
Comment on attachment 8898197 [details] [diff] [review]
bug1391185.patch

Review of attachment 8898197 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8898197 - Flags: review?(bbouvier) → review+
Dragan: I've assigned you to the bug and set the checkin-needed keyword for you, so that it can land.

Can you please check if you have sufficient rights to do this by yourself? (you can try on bug 1391248)
Assignee: nobody → dragan.mladjenovic
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(dragan.mladjenovic)
Keywords: checkin-needed
(Assignee)

Comment 4

2 years ago
(In reply to Benjamin Bouvier [:bbouvier] from comment #3)
> Dragan: I've assigned you to the bug and set the checkin-needed keyword for
> you, so that it can land.
> 
> Can you please check if you have sufficient rights to do this by yourself?
> (you can try on bug 1391248)

Hi,

Thanks. It seems that I do have sufficient rights to change issue keywords.

PS: Is there a publicly accessible buildbot/trybot-like service for spidermonkey where I can see what kind of test suits are run for different platforms and their current status?
Flags: needinfo?(dragan.mladjenovic)
Good to know!

Yes, we do have a try-server that allows developers to run their changes as in CI: https://wiki.mozilla.org/ReleaseEngineering/TryServer

Unfortunately, MIPS is supported as "tier-3" platform, which means that we don't compile-and-run-tests in automation on MIPS platforms or simulators.

See a typical try build for the JS engine here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=82d0d1e1fc2ac03de250d57cb74797f787d83491

Note this is the same automation used in production in inbound (our "trunk" branch): https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound

For changes related to the JITs, you could locally use the following to make sure your patches passes tests:

${MOZILLA_CLONE_ROOT}/js/src/jit-test/jit_test.py path/to/your/spidermonkey/build/dist/bin/js ${KEYWORD}

where ${KEYWORD} is either nothing (and this will run **all** the jit tests, which might take a while, between 30 to 60 minutes), or any word that would appear as substring of a subset of test filenames (e.g., if KEYWORD is wasm, you'll run all the wasm tests).

Please let me know if you need more information. I'm available on irc (:bbouvier on #jsapi or #ionmonkey on irc.mozilla.org) or by email.

Comment 6

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ccc616a23b3
Add missing implementation for MacroAssembler::moveValue to mips32. r=bbouvier
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8ccc616a23b3
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.