Closed Bug 1391217 Opened 7 years ago Closed 7 years ago

Remove unused @namespace svg at-rules

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: dao, Assigned: ikram, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=css])

Attachments

(1 file)

We define the SVG namespace in a bunch of CSS files:

http://searchfox.org/mozilla-central/search?q=namespace+svg&case=false&regexp=false&path=browser%2F

But none of these files have rules using svg|.
I am going to upload a patch soon. Hence assigning myself :)
Assignee: nobody → hossainalikram
Status: NEW → ASSIGNED
Are you still going to submit a patch?
Flags: needinfo?(hossainalikram)
Attached patch firstpatch.patchSplinter Review
Let me know, if their is any modification I should do :)
Flags: needinfo?(hossainalikram)
Attachment #8904707 - Flags: review?(dao+bmo)
Comment on attachment 8904707 [details] [diff] [review]
firstpatch.patch

Looks good. Thanks!
Attachment #8904707 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4e16883efd9
Remove unused @namespace svg at-rules. r=dao
https://hg.mozilla.org/mozilla-central/rev/f4e16883efd9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.