1391231 - Use the list provided by .clang-format-ignore instead of only thirdpartypath.txt

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

The thirdparty list only contains thirdparty code but we also want to ignore some of our code.

As .clang-format-ignore also contains the content of thirdparthpath.txt, let's us this one (especially as we can use regexp now)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1391231 - Use the list provided by .clang-format-ignore instead of only thirdpartypath.txt

Review commit: https://reviewboard.mozilla.org/r/169636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169636/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

As an example:
$ ./mach clang-format -p dom/presentation/ toolkit/components/protobuf/  config/gcc-stl-wrapper.template.h
clang-format: Ignored third party code 'toolkit/components/protobuf/'
clang-format: Ignored third party code 'config/gcc-stl-wrapper.template.h'

I landed this patch upstream:
https://reviews.llvm.org/rL310778
to have a better display in the tool

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8898271 [details]
Bug 1391231 - Use the list provided by .clang-format-ignore instead of only thirdpartypath.txt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169636/diff/1-2/

Comment 4

[Sylvestre Ledru [:Sylvestre]]

The ignore list will be also used when doing
./mach clang-format -p .

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8898271 [details]
Bug 1391231 - Use the list provided by .clang-format-ignore instead of only thirdpartypath.txt

https://reviewboard.mozilla.org/r/169636/#review175392

FWIW, the use of regular expressions for path matching as employed by ``.clang-ignore-patterns`` and used in this file hits scaling limits. I know because Mercurial has dealt with this problem on several fronts. glob based matching (using ``*``) to denote wildcards is much better (especially if you can limit the wildcard to only occurring at the end of the string). I'm not sure if this will be a problem for us. But it is worth mentioning just so it is on your radar.

::: tools/mach_commands.py:293
(Diff revision 2)
> +        ignored_dir_re = '(%s)' % '|'.join(ignored_dir)
>          extensions = ('.cpp', '.c', '.h')
>  
>          path_list = []
>          for f in paths:
> -            if f.startswith(ignored_dir):
> +            import re

You can move this to module level: this module is already imported elsewhere.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8898271 [details]
Bug 1391231 - Use the list provided by .clang-format-ignore instead of only thirdpartypath.txt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169636/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6c847346cb6
Use the list provided by .clang-format-ignore instead of only thirdpartypath.txt r=gps

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b6c847346cb6