Closed
Bug 1391278
Opened 8 years ago
Closed 8 years ago
Cleanup: Don't shadow mMonitor, Image and mImageContainer in MediaEngineDefault derived class.
Categories
(Core :: WebRTC: Audio/Video, enhancement, P1)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
DUPLICATE
of bug 1374164
People
(Reporter: jib, Assigned: jib)
Details
Attachments
(1 file)
In MediaEngineDefault.h mMonitor, Image and mImageContainer are shadowing protected (not private) members of the same name in the base class MediaEngineCameraVideoSource (when MOZ_WEBRTC is defined).
This leads to confusion about which members are used/cleared, e.g. in bug 1374164 and bug 1088621.
We should either rename them, or use the base members. Since MediaEngineDefault primarily exists to test the base class, I'm leaning toward the latter.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jib
|
||
Updated•8 years ago
|
Rank: 17
Priority: -- → P1
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8898335 [details]
Bug 1391278 - Don't shadow mMonitor, Image and mImageContainer in MediaEngineDefault derived class.
https://reviewboard.mozilla.org/r/169682/#review175144
Attachment #8898335 -
Flags: review?(rjesup) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Patch is in bug 1374164.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•