1391288 - rebuild the decision image to pick up changes from bug 1384210, 1389715

Status: RESOLVED FIXED

(Taskcluster Graveyard :: Docker Images, enhancement)

Description

[Tom Prince [:tomprince]]

I need this for porting comm-central to taskcluster, so the image referenced by gecko's .taskcluster.yml doesn't need to be updated. It may make sense to update it anyway to avoid later confusion; in which case the additional changes done in bug 1350045 also need to be done to avoid breaking chain-of-trust.

Comment 1

[Tom Prince [:tomprince]]

Actually, the changes from bug 1389715 are probably important to pick up too.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I'm running quite behind on getting stuff done but I'll put this on my queue.  If someone steals it before I get to it, that's great :)

Comment 3

[Greg Arndt [:garndt]]

going to take a stab at this one and see if I remember how to do this :)

Comment 4

[Gregory Szorc [:gps]]

I have permissions to push the Docker image for the decision image if you need my help.

Comment 5

[Greg Arndt [:garndt]]

try push using new decision task:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=699593f7c6c38c4d71f07b08b5ba2969561b4f35&selectedJob=123941666

Comment 6

[Greg Arndt [:garndt]]

Attachment: Bug 1391288 - Rebuild decision task image with new robustcheckout

Review commit: https://reviewboard.mozilla.org/r/169820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169820/

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 8898439 [details]
Bug 1391288 - Rebuild decision task image with new robustcheckout

https://reviewboard.mozilla.org/r/169820/#review175040

Don't forget to coordinate with aki to get the new image hooked up to chain of trust. This can't land until that's done.

Comment 8

[Greg Arndt [:garndt]]

Published "taskcluster/decision:0.1.9@sha256:9d6a38ff675ba2f2f132bc1461e3a48b0ce56c90617a8a5c5f8c48c6eb8d06e0" and submitted patch for review containing this new image.

Image was built off of the most recent mozilla-central.  This cannot be merged until puppet and scriptworker are updated.

Comment 9

[Greg Arndt [:garndt]]

Attachment: Scriptworker PR

This same hash needs to be added as a puppet patch too, which I have never done.

Comment 10

[Aki Sasaki (not active)]

Attachment: decision-puppet.diff

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8898439 [details]
Bug 1391288 - Rebuild decision task image with new robustcheckout

https://reviewboard.mozilla.org/r/169820/#review175044

I believe you! :)

Comment 12

[Aki Sasaki (not active)]

Landed on https://hg.mozilla.org/build/puppet/rev/1b02d9e56bed ; merged to production. Once that rolls out we should be good to land in-tree... within the hour I believe.

Comment 13

[Greg Arndt [:garndt]]

Circling back on this, did all the prerequisites of the in-tree changes land now?  If so, we should be able to land this.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9af86588527a
Rebuild decision task image with new robustcheckout r=dustin,gps

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9af86588527a

Comment 16

[Greg Arndt [:garndt]]

gps, thank you for landing this.