Closed Bug 1391294 Opened 7 years ago Closed 7 years ago

return 404s instead of empty xml in public api

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P3)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: asilva, Mentored)

Details

(Whiteboard: [lang=python][ready])

Because the public api lives in the same wsgi app as app updates, it inherited the behaviour of returning an empty xml file. This is really surprising and bad behaviour for the API - we should fix it. I think we can tweak https://github.com/mozilla/balrog/blob/8074b852845ae79e2cc81f1e90ab1a1191c11835/auslib/web/public/base.py#L62 to only return the empty XML if the path starts with "update" (and return the error otherwise).
Allan is working on this in https://github.com/mozilla/balrog/pull/373.
Assignee: nobody → allan.tavares
Status: NEW → ASSIGNED
Commit pushed to master at https://github.com/mozilla/balrog https://github.com/mozilla/balrog/commit/dfb5c1b0b4d8229129f8a608ca0c2b4882ba5078 bug 1391294: Return 404 for non-update endpoints (#373). r=bhearsum
Deployed to production yesterday, thanks Allan!
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.