Closed
Bug 1391304
Opened 7 years ago
Closed 7 years ago
Inline IsCallable when called with MIRType::Value
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
10.48 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Calls to IsCallable when calling each Speedometer framework once from InteractiveRunner.html: Before: Vanilla 643 Vanilla2015 444 Vanilla-babel 559 React 8883 React-Redux 3643 Ember 8835 Backbone 7091 AngularJS 17525 Angular2 522 Vue 433 jQuery 7368 Preact 570 Inferno 611 Elm 1834 Flight 5426 After: Vanilla 507 Vanilla2015 608 Vanilla-babel 583 React 6604 React-Redux 4118 Ember 3812 Backbone 4127 AngularJS 6900 Angular2 671 Vue 432 jQuery 5221 Preact 545 Inferno 661 Elm 1930 Flight 2608
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8898367 -
Flags: review?(jdemooij)
Comment 2•7 years ago
|
||
Comment on attachment 8898367 [details] [diff] [review] bug1391304.patch Review of attachment 8898367 [details] [diff] [review]: ----------------------------------------------------------------- Beautiful, thanks.
Attachment #8898367 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c94993d0bd5230f391512f0b30ca2642646896e8
Keywords: checkin-needed
Comment 4•7 years ago
|
||
André, if you want L3 commit access just file the bug; I'm happy to vouch and I'm sure we can find plenty of others to do the same :)
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #4) > André, if you want L3 commit access just file the bug; I'm happy to vouch > and I'm sure we can find plenty of others to do the same :) Yeah, I guess I should request L3 access, especially when the Phabricator platform goes online and most patches should land through Autoland... (Autoland requires author and/or reviewer has L3 access to push, doesn't it?)
Comment 6•7 years ago
|
||
(In reply to André Bargull from comment #5) > Yeah, I guess I should request L3 access, especially when the Phabricator > platform goes online and most patches should land through Autoland... > (Autoland requires author and/or reviewer has L3 access to push, doesn't it?) I don't know. I'm happily using Splinter until it's taken away from me ;)
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/31625e5ae768 Inline IsCallable when called with MIRType::Value. r=jandem
Keywords: checkin-needed
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/31625e5ae768
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 9•7 years ago
|
||
FWIW I'll happily vouch for you if you want as well, André! I have been watching your great work from a distance for a while now. If needed please feel free to needinfo me on the L3 commit access bug. :-)
Comment 10•7 years ago
|
||
Same here. Would be happy vouch based on your work on Intl API.
You need to log in
before you can comment on or make changes to this bug.
Description
•