Closed
Bug 1391316
Opened 7 years ago
Closed 7 years ago
Remove VoEHardware from MediaEngineWebrtc
Categories
(Core :: WebRTC: Audio/Video, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: dminor, Assigned: dminor)
Details
Attachments
(1 file)
|
5.47 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
The VoEHardware interface has been removed upstream in branch 61. We can switch to calling into AudioDeviceModule. This is only used in the non-full duplex code path.
|
Assignee | |
Updated•7 years ago
|
Rank: 19
|
|
Assignee | |
Comment 1•7 years ago
|
||
I not certain if we have coverage for non-full duplex in automation. I tested this by turning off full duplex and making appear.in calls.
Attachment #8898383 -
Flags: review?(rjesup)
|
||
Updated•7 years ago
|
Attachment #8898383 -
Flags: review?(rjesup) → review+
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bc93b3a25d44 Remove VoEHardware from MediaEngineWebrtc; r=jesup
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bc93b3a25d44
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•