Closed Bug 1391321 Opened 7 years ago Closed 7 years ago

[meta] port custom-ui actions in treeherder to use actions.json if available

Categories

(Taskcluster :: Services, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bstack, Assigned: bstack)

References

Details

Attachments

(1 file)

      No description provided.
Blocks: 1381082, 1388496, 1388508, 1390497, 1390986
No longer blocks: 1370343
Attachment #8898473 - Flags: review?(cdawson)
Comment on attachment 8898473 [details] [review]
[treeherder] imbstack:bug-1391321 > mozilla:master

Just a couple minor things.  And it looks like there were some unanswered questions from Dustin?  Esp: the "trying the old way first" one.  :)
Attachment #8898473 - Flags: review?(cdawson) → review-
Attachment #8898473 - Flags: review- → review?
Thanks bstack--  I think this is about ready to go.  Just a couple comments in the PR.  Let me know if you need me to merge. I believe you have access to do so now.  :)
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e918b4e1b1263acb9a45f3487182f6d7fc2f8156
Bug 1391321 - Use taskcluster actions.json for all actions (#2718)

Bug 1391321 - Use taskcluster actions.json for all actions
Thanks for the access :)

This is all merged in now.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
More history from IRC, for posterity:

00:52 <KWierso> so, the possible combinations we have are:
00:52 <KWierso> in-tree without bstack's stuff + current treeherder prod
00:52 <KWierso> in-tree without bstack's stuff + current treeherder master
00:52 <KWierso> in-tree with bstack's stuff + current treeherder prod
00:52 <KWierso> in-tree with bstack's stuff + current treeherder master
00:53 <KWierso> which of these result in not being able to add jobs/backfill?
00:53 <KWierso> is there any way to get all of them to work?
00:53 <KWierso> (backward compatible from both sides?)
00:53 <bstack> iiuc even currently certain things are broken for certain pushes
00:54 <bstack> the logic in-tree itself is broken for a few days for actions.yml and a week or so for actions.json
00:54 <bstack> which is all fallout from some change somebody made to decision tasks
00:54 <bstack> which is my long-way-around way of saying that I don't think we can have a way that makes all 4 cases work
00:55 <bstack> and I think some subset of the 4 is actually currently broken
00:55 <bstack> but I'm not an expert on what is actually broken here
00:55 <bstack> my changes just relied on this working :/
00:55 <KWierso> I have seen some busted Action tasks on various trees today
00:55 <KWierso> (the "A" symbols, not "add-new")
00:56 <bstack> yeah, that makes sense I believe
00:56 <camd> I guess it all depends on where we're most "danged if we do/don't"
00:57 <camd> perhaps pushing to prod tomorrow would be worth it so at least all the new stuff will work?  KWierso do you have a feel for that?

I'm going to do a prod deploy today.

If people have problems using action tasks, they need to update to newer mozilla-central.

Ideally in the future in-tree changes could be forwards/backwards compatible to avoid too much breakage.
Depends on: 1397527
Attachment #8898473 - Flags: review?
Component: Integration → Services
You need to log in before you can comment on or make changes to this bug.