Support force reloading via keyboard

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: JanH, Assigned: dmurray501, Mentored)

Tracking

Trunk
Firefox 57
All
Android
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [good first bug][lang=java])

Attachments

(3 attachments)

At the moment, pressing Ctrl + R on a hardware keyboard (or using a software keyboard that supports this, e.g. Hacker's Keyboard) reloads the page, but it's not possible to trigger a forced reload bypassing the cache by pressing Ctrl + Shift + R.

This is the place to add the required additional logic:
https://dxr.mozilla.org/mozilla-central/rev/63ca686c3f1e870649b6d9c559973d100573aec2/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#545

Comment 1

2 years ago
Hi. I would glad to work on this. Looks like good place to start contributing =)

Updated

2 years ago
Flags: needinfo?(jh+bugzilla)
Hi, welcome. Sure, feel free to go ahead and work on this.

If you haven't already got a Firefox build going, you can find instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Instructions on how to submit a patch are here:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#mozreview-install

And if you've got any further questions, just ask or drop by on IRC (https://wiki.mozilla.org/IRC) in #mobile.
Flags: needinfo?(jh+bugzilla)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8903965 - Flags: review?(kowasockilendaro)
Attachment #8903965 - Flags: review?(jh+bugzilla)
Reporter

Comment 6

2 years ago
mozreview-review
Comment on attachment 8903965 [details]
Bug 1391355 - add force reload support via keyboard

https://reviewboard.mozilla.org/r/175718/#review180746

Looks fine.
Attachment #8903965 - Flags: review?(jh+bugzilla) → review+
Attachment #8903965 - Flags: review?(kowasockilendaro)
So from talking with Min Yu/ImTheRealOne I understand we're going with your patch this time.

I've triggered a run on our try server for the patch - in this case the patch is small and simple enough (and I don't think we've actually got any tests specifically for keyboard shortcuts - might be an idea for a later follow-up bug if anybody feels up to it), but it's still a good practice for more complex patches.
You can follow the progress here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a0d341399f1

Assuming there are no unexpected failures, you can then edit this bug and set the "checkin-needed" keyword to actually land the patch in our repository.
Assignee: nobody → dmurray501
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 8

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3ba65c513e8c
add force reload support via keyboard r=JanH
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3ba65c513e8c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.