1391355 - Support force reloading via keyboard

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, enhancement)

Description

[Jan Henning [:JanH]]

At the moment, pressing Ctrl + R on a hardware keyboard (or using a software keyboard that supports this, e.g. Hacker's Keyboard) reloads the page, but it's not possible to trigger a forced reload bypassing the cache by pressing Ctrl + Shift + R.

This is the place to add the required additional logic:
https://dxr.mozilla.org/mozilla-central/rev/63ca686c3f1e870649b6d9c559973d100573aec2/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#545

Comment 1

[Maxim Zalata]

Hi. I would glad to work on this. Looks like good place to start contributing =)

Comment 2

[Jan Henning [:JanH]]

Hi, welcome. Sure, feel free to go ahead and work on this.

If you haven't already got a Firefox build going, you can find instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Instructions on how to submit a patch are here:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#mozreview-install

And if you've got any further questions, just ask or drop by on IRC (https://wiki.mozilla.org/IRC) in #mobile.

Comment 3

[David Murray]

Attachment: Bug 1391355 - add force reload support via keyboard

Review commit: https://reviewboard.mozilla.org/r/175718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175718/

Comment 4

[Min Yu]

Attachment: Bug 1391355 - Support force reloading via keybaord

Review commit: https://reviewboard.mozilla.org/r/175722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175722/

Comment 5

[Min Yu]

Attachment: Bug 1391355 - Support force reloading via keyboard

Review commit: https://reviewboard.mozilla.org/r/175724/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175724/

Comment 6

[Jan Henning [:JanH]]

Comment on attachment 8903965 [details]
Bug 1391355 - add force reload support via keyboard

https://reviewboard.mozilla.org/r/175718/#review180746

Looks fine.

Comment 7

[Jan Henning [:JanH]]

So from talking with Min Yu/ImTheRealOne I understand we're going with your patch this time.

I've triggered a run on our try server for the patch - in this case the patch is small and simple enough (and I don't think we've actually got any tests specifically for keyboard shortcuts - might be an idea for a later follow-up bug if anybody feels up to it), but it's still a good practice for more complex patches.
You can follow the progress here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a0d341399f1

Assuming there are no unexpected failures, you can then edit this bug and set the "checkin-needed" keyword to actually land the patch in our repository.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ba65c513e8c
add force reload support via keyboard r=JanH

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3ba65c513e8c