Limit add-ons loaded into Firefox for Android

VERIFIED FIXED in Firefox 57

Status

()

Toolkit
WebExtensions: Android
P2
normal
VERIFIED FIXED
9 months ago
7 months ago

People

(Reporter: Andy McKay, Assigned: aswan)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified, firefox58 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
This is a repeat of the work for Firefox Desktop. Create the pref (if its not there already), default it to true, do not allow it to be changed on beta and release.

At this time we do not expect to do any other work on the add-ons manager in Android.
(Reporter)

Updated

9 months ago
Flags: needinfo?(kev)
Flags: needinfo?(jcheng)

Comment 1

9 months ago
Agreed. Plan has been to remove the ability to load legacy addons in 57 for Android, and we need to land it. Simple change of disabling legacy addons w/57.
Flags: needinfo?(kev)
ni EPM Wesly to get it into sprint planning
tracking-fennec: --- → ?
Flags: needinfo?(jcheng) → needinfo?(wehuang)

Comment 3

9 months ago
Andy, sorry for few simple questions:

1. There is a Trello card (https://trello.com/c/jh2qkMTs) with bug 1336576 tracking related work, should I assume this Bug 1391401 is dedicated for Android so the right one to replace bug 1336576 on that Trello card (https://trello.com/c/jh2qkMTs), as the card is titled "Fennec"?

2. Does your team plan to take this bug like the other add-on tasks, or you expect anything to be done by the front-end team in Taipei?

3. I don't have the background about the work, why should we have a pref in Nightly and this pref shouldn't be changed on beta and release? We intend to leave a switch in only Nightly to let people turn on the legacy add-on support? (i.e., to disable the limit of legacy)

Thanks.
Flags: needinfo?(wehuang) → needinfo?(amckay)
(Reporter)

Comment 4

9 months ago
(In reply to Wesly Huang (Fennec Frontend/Firefox EPM) from comment #3)
> Andy, sorry for few simple questions:
> 
> 1. There is a Trello card (https://trello.com/c/jh2qkMTs) with bug 1336576
> tracking related work, should I assume this Bug 1391401 is dedicated for
> Android so the right one to replace bug 1336576 on that Trello card
> (https://trello.com/c/jh2qkMTs), as the card is titled "Fennec"?

Yup.

> 2. Does your team plan to take this bug like the other add-on tasks, or you
> expect anything to be done by the front-end team in Taipei?

We were going to do it, but if you'd like to ... :)
 
> 3. I don't have the background about the work, why should we have a pref in
> Nightly and this pref shouldn't be changed on beta and release? We intend to
> leave a switch in only Nightly to let people turn on the legacy add-on
> support? (i.e., to disable the limit of legacy)

We intend to leave the flag flippable in Nightly so that users can developer new system add-ons, experiments etc. outside of the WebExtension APIs.
Flags: needinfo?(amckay)

Comment 5

9 months ago
Thanks Andy and clear, I will

1. update the Trello card (https://trello.com/c/jh2qkMTs)accordingly.
2. let the experts (your team) handle this bug : )

(In reply to Andy McKay [:andym] from comment #4)
> (In reply to Wesly Huang (Fennec Frontend/Firefox EPM) from comment #3)
> > Andy, sorry for few simple questions:
> > 
> > 1. There is a Trello card (https://trello.com/c/jh2qkMTs) with bug 1336576
> > tracking related work, should I assume this Bug 1391401 is dedicated for
> > Android so the right one to replace bug 1336576 on that Trello card
> > (https://trello.com/c/jh2qkMTs), as the card is titled "Fennec"?
> 
> Yup.
> 
> > 2. Does your team plan to take this bug like the other add-on tasks, or you
> > expect anything to be done by the front-end team in Taipei?
> 
> We were going to do it, but if you'd like to ... :)

Comment 6

9 months ago
Guess we could remove the fennec? tracking ?
(Reporter)

Updated

9 months ago
Priority: -- → P2

Updated

9 months ago
tracking-fennec: ? → ---
(Reporter)

Updated

9 months ago
Assignee: nobody → aswan
(Assignee)

Comment 7

8 months ago
Everything from comment 0 except for "default it to true" (*) is already handled in toolkit so all we need to do here is flip the default for Fennec.  I'm running it through try right now but assuming nothing breaks, this will be trivial.

* The preference is actually whether legacy extensions are allowed so the change is to make false the default, not true.
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Attachment #8907799 - Flags: review?(kmaglione+bmo)
Comment on attachment 8907799 [details]
Bug 1391401 Disable legacy extensions by default on Android

https://reviewboard.mozilla.org/r/179490/#review184736
Attachment #8907799 - Flags: review?(kmaglione+bmo) → review+

Comment 10

8 months ago
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/337bae3d28e4
Disable legacy extensions by default on Android r=kmag

Updated

8 months ago
Depends on: 1399687

Comment 11

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/337bae3d28e4
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57

Updated

8 months ago
Depends on: 1405990

Comment 12

7 months ago
Hi Andrew
In Fennec we need a special Switchboard Experiment add-on written by Sebastian to configure Fennec during runtime
https://addons.mozilla.org/en-US/android/addon/switchboard-experiments/

but now even I set extensions.legacy.enabled to true, I can't install the xpi from disk anymore.( it was working at 57 beta 1~2)

Is it possible to make this Switchboard add-on an exception to the legacy add0on using similar approach like this?
https://searchfox.org/mozilla-central/rev/31606bbabc50b08895d843b9f5f3da938ccdfbbf/browser/app/profile/firefox.js#92

Or is there another way we can install legacy add-ons just for QA testing?
Flags: needinfo?(wehuang)
Flags: needinfo?(aswan)
(Assignee)

Comment 13

7 months ago
The preference from your searchfox link just controls things in the about:addons UI in desktop Firefox.
The usual thing we do for this sort of testing is temporary installation.  In desktop, this is done from about:debugging but I don't believe that exists on Fennec.  I know it is possible using a patched version of the web-ext command line tool [1]
I've added :rpl to the CC list as well, he might have some additional ideas.  Though if this turns into a longer discussion it might make sense to take it to email or something instead of comments on a resolved bug...

[1] https://github.com/mozilla/web-ext/pull/868
Flags: needinfo?(aswan)

Comment 14

7 months ago
This issue is verified as fixed on Fennec 58.0a1(2017-10-17) and Fennec 57.0b9 under Android 6.0.1, the preference extensions.legacy.enabled is displayed in about:config and is set to false by default.

The preference is not honored on Beta or Release, it only works on Nightly and Dev Edition builds.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
status-firefox58: --- → verified

Updated

7 months ago
Flags: needinfo?(wehuang)
You need to log in before you can comment on or make changes to this bug.