Closed
Bug 1391517
Opened 8 years ago
Closed 8 years ago
Fix missing Firefox Account profile avatar & shrink sync settings checkbox width
Categories
(Firefox :: Settings UI, defect, P1)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | verified |
People
(Reporter: rickychien, Assigned: rickychien)
References
(Blocks 1 open bug)
Details
(Whiteboard: [photon-preference])
Attachments
(1 file)
Missing account avatar after login is a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1361952#c33.
Assignee | ||
Updated•8 years ago
|
Summary: Update Firefox Account to match the spec → Fix missing Firefox Account profile avatar
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•8 years ago
|
||
I also spotted an another issue that the checkbox width of "Sync Settings" in Firefox Account page doesn't follow the visual spec [1]. The checkbox width should be set to 224px (216px + 8px) according to spec.
Patch has been updated for fixing checkbox width as well. Thanks
[1] https://mozilla.invisionapp.com/share/X8BGCX9PD#/screens/244683212
Summary: Fix missing Firefox Account profile avatar → Fix missing Firefox Account profile avatar & shrink sync settings checkbox width
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8898599 [details]
Bug 1391517 - Fix missing fxa profile avatar & shrink checkbox width
https://reviewboard.mozilla.org/r/169988/#review175164
::: browser/components/preferences/in-content-new/sync.js:334
(Diff revision 2)
> } else {
> fxaLoginStatus.removeAttribute("hasName");
> }
> if (data.avatar) {
> let bgImage = "url(\"" + data.avatar + "\")";
> - let profileImageElement = document.getElementById("fxaProfileImage");
> + let profileImageElement = document.querySelector("#fxaLoginVerified > #fxaProfileImage");
We shouldn't have more than one element on a page that shares the same ID. This basically breaks fundamental assumptions of how IDs work.
Can you please change all #fxaProfileImage to be classes?
Same thing for #fxaLoginRejectedWarning too please.
Attachment #8898599 -
Flags: review?(jaws) → review-
Comment hidden (mozreview-request) |
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8898599 [details]
Bug 1391517 - Fix missing fxa profile avatar & shrink checkbox width
https://reviewboard.mozilla.org/r/169988/#review175170
Attachment #8898599 -
Flags: review?(jaws) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c617506930e
Fix missing fxa profile avatar & shrink checkbox width r=jaws
Updated•8 years ago
|
Whiteboard: [photon-preference][triage] → [photon-preference]
Comment 8•8 years ago
|
||
bugherder |
Comment 9•8 years ago
|
||
Build ID: 20170829100404
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•