1391556 - firefox-55.0.2/media/libstagefright/system/core/liblog/fake_log_device.c:155: array index out of bounds ?

Status: RESOLVED FIXED

(Core :: Audio/Video, enhancement)

Description

[David Binderman]

What did you do?
================
1. 
2. 
3. 

What happened?
==============
firefox-55.0.2/media/libstagefright/system/core/liblog/fake_log_device.c:155]: (error) Array 'openLogTable[16]' accessed at index 127, which is out of bounds.

Source code is

    for (i = 0; i < sizeof(openLogTable); i++) {

but

static LogState *openLogTable[MAX_OPEN_LOGS];


What should have happened?
==========================
Better source code 

    for (i = 0; i < MAX_OPEN_LOGS; i++) {


Is there anything else we should know?
======================================

Comment 1

[John Whitlock [:jwhitlock]]

In context:

https://dxr.mozilla.org/mozilla-central/source/media/libstagefright/system/core/liblog/fake_log_device.c?q=sizeof%28openLogTable%29&redirect_type=single#154

Comment 2

[John Lin [:jhlin][:jolin]]

(In reply to David Binderman from comment #0)
> ==========================
> Better source code 
> 
>     for (i = 0; i < MAX_OPEN_LOGS; i++) {
> 

 Or |i < (sizeof(openLogTable) / sizeof(openLogTable[0]))|, but I like your solution better.

 It's a fixed issue in upstream stagefright that isn't pulled into Gecko.

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1391556 - fix incorrect out of bound check.

Review commit: https://reviewboard.mozilla.org/r/170968/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170968/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8899656 [details]
Bug 1391556 - fix incorrect out of bound check.

https://reviewboard.mozilla.org/r/170968/#review176122

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a402ebd682d2
fix incorrect out of bound check. r=jwwang

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a402ebd682d2