Closed Bug 1391610 Opened 3 years ago Closed 3 years ago

Rename savedLoginsExceptions_desc2 to reflect string change

Categories

(Firefox :: Preferences, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox57 --- verified

People

(Reporter: flod, Assigned: evanxd)

References

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

> -savedLoginsExceptions_desc2=Logins for the following websites will not be saved:
> +savedLoginsExceptions_desc2=Logins for the following websites will not be saved

This string changed without a new ID.
Assignee: nobody → evan
Whiteboard: [photon-preference]
Attachment #8906988 - Flags: review?(mconley)
Hi Mike,

Could you help review the patch?

The bug is about the `Logins for the following websites will not be saved:` string is changed to `Logins for the following websites will not be saved` without a new ID in Bug 1382135. The only thing we did in the patch is changing the string ID.

Thank you.
Status: NEW → ASSIGNED
Flags: qe-verify+
QA Contact: hani.yacoub
Comment on attachment 8906988 [details]
Bug 1391610 - Rename savedLoginsExceptions_desc2 as savedLoginsExceptions_desc3 since we updated the string in Bug 1382135 without changing the ID.

https://reviewboard.mozilla.org/r/178748/#review183734

This seems trivial enough for me to steal the review
Attachment #8906988 - Flags: review+
Attachment #8906988 - Flags: review?(mconley)
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/f1e8596a1f89
Rename savedLoginsExceptions_desc2 as savedLoginsExceptions_desc3 since we updated the string in Bug 1382135 without changing the ID. r=flod
Thank you for the review, Francesco. Let's land the patch.
Keywords: checkin-needed
I landed it several hours ago (comment 4) ;-)
Keywords: checkin-needed
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/f1e8596a1f89
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Build ID: 20170914100122
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Windows 7 x32, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.