Closed Bug 1391639 Opened 7 years ago Closed 7 years ago

JSOP_IN often not optimized on Speedometer's Elm benchmark

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1357759

People

(Reporter: jandem, Assigned: tcampbell)

References

(Blocks 1 open bug)

Details

We make a ton of calls to IonInIC::update and OperatorIn on the Elm benchmark.

I didn't investigate why, but I'm pretty sure we need a megamorphic stub for this (we have one for JSOP_HASOWN but not JSOP_IN).
(Still hard to believe we didn't even have an Ion IC for this until bug 1337773, Firefox 55 :)
Depends on: 1361731
Priority: -- → P3
Assignee: nobody → tcampbell
Status: NEW → ASSIGNED
Looks like it was actually missing proxy support. Patches on Bug 1357759 seem to fix all remaining failed ICs in firefox startup + speedometer except for things with Resolve hooks (XPCComponents_Interfaces, XPCWrappedNative_NoHelper, and ArgumentsObjects).
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.