Closed
Bug 1391640
Opened 8 years ago
Closed 8 years ago
Use Services.ww instead of importing nsIWindowWatcher
Categories
(SeaMonkey :: General, enhancement)
SeaMonkey
General
Tracking
(seamonkey2.53 fixed, seamonkey2.54 fixed)
RESOLVED
FIXED
seamonkey2.54
People
(Reporter: frg, Assigned: frg)
Details
Attachments
(1 file)
|
16.75 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
While working on bug 1379369 I came accross openWindow. Most call in suite import nsIWindowWatcher via a variable. This can be simplified by just using Services.ww
|
Assignee | |
Comment 1•8 years ago
|
||
When I was unable to keep the character count under 80 chars I aligned at column 2 for the Services call.
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: None. Just wanting to make the SeaMonkey source a better place to live. Might be 0.01 seconds faster too in some situations :)
Testing completed (on m-c, etc.): c-b
Risk to taking this patch (and alternatives if risky): none tested and simple.
String changes made by this patch: none
Attachment #8898789 -
Flags: review?(iann_bugzilla)
Attachment #8898789 -
Flags: approval-comm-beta?
Comment on attachment 8898789 [details] [diff] [review]
1391640-nsIWindowswatcher.patch
LGTM r/a=me
There is also window-mediator but that can be another bug.
Attachment #8898789 -
Flags: review?(iann_bugzilla)
Attachment #8898789 -
Flags: review+
Attachment #8898789 -
Flags: approval-comm-beta?
Attachment #8898789 -
Flags: approval-comm-beta+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/9a3cdb27f992
User Services.ww instead of importing nsIWindowWatcher in SeaMonkey. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•8 years ago
|
||
status-seamonkey2.53:
--- → fixed
status-seamonkey2.54:
--- → fixed
Target Milestone: --- → seamonkey2.54
You need to log in
before you can comment on or make changes to this bug.
Description
•