1391668 - make it possible to force a background check

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P3)

Description

[[e-mail] (:bhearsum)]

Currently, the only way to see what a background update check is getting offered is to request an URL without force=1 set (eg: https://aus5.mozilla.org/update/3/Firefox/33.0/20141202185629/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/release/default/default/default/update.xml) and hope that you get on the correct side of the dice roll. This can be finnicky, and it's a hinderance to writing automated tests to verify rules.

Just like we can force a manual check by setting force=1, we should have a way to force a background check. Maybe this could be force=0, or unforce=1, or background=1.

Having this would make it easy to write tests that verify the primary and fallback mappings (just make two requests!). It wouldn't help verify that a particular background rate is set.

Comment 1

[Cosm]

Hi, I want to work on this issue.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Cosm from comment #1)
> Hi, I want to work on this issue.

Unfortunately, someone has already submitted a pull request for this.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/9653937820f2722f94bb68aa131cad66606c43b3
bug 1391668: make it possible to force a background check (#382). r=bhearsum

Comment 4

[[e-mail] (:bhearsum)]

For posterity, we ended up going with force=-1 to force a background check.

Comment 5

[[e-mail] (:bhearsum)]

This is now in production - thanks Ethan!