1391853 - --filter option does not work with ./mach jstestbrowser

Status: RESOLVED FIXED

(Testing :: Reftest, enhancement)

Description

[Andrew McCreight [:mccr8]]

If I try to use the filter option, like this:
  ./mach jstestbrowser --filter transferables
Then it fails to actually run any tests.

The root of the issue seems to be:
REFTEST ERROR | EXCEPTION: [Exception... "Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService.newURI]"  nsresult: "0x804b000a (NS_ERROR_MALFORMED_URI)"  location: "JS frame :: chrome://reftest/content/reftest.jsm :: ReadTopManifest :: line 831"  data: no]

When StartTests() iterates does "manifestURLs.forEach(function(manifestURL) {", manifestURL seems to be undefined, and then we try to convert undefined into a URI and we get that error. I don't know how this is supposed to work, or why it only fails with --filter.

Comment 1

[Steve Fink [:sfink] [:s:]]

So.... this appears to be a duplicate of bug 1468677, except that the exact command above will still run no tests. I believe this is due to bug 1611473.

I would mark this as a duplicate of bug 1611473, except I thought I could get this to run with
./mach jstestbrowser --filter transferables obj-debug/dist/test-stage/jsreftest/tests/js/src/tests/jstests.list but that doesn't do anything either. So I'll leave this alone until I look into what's actually happening, assuming I ever do.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1391853 - Update the code to receive --filter option from pref. r?jmaher!

manifest[""] value is modified from filter string to [filter string, null]
array, in bug 1596567.

Updated the reftest.jsm side to follow the convension, and also added some
runtime check, to catch future change.

Comment 3

[Tooru Fujisawa [:arai]]

looks like, there were 2 issues, one was the comment #0, that seems to be solved at some point,
and then bug 1596567 introduced another issue, that's inconsistency between python side and JS side

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72ca28c9fe34
Update the code to receive --filter option from pref. r=jmaher

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/72ca28c9fe34