Closed Bug 1392003 Opened 3 years ago Closed 3 years ago

Support estimatedEndTime in DownloadItem

Categories

(WebExtensions :: Request Handling, enhancement, P5)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: wisniewskit, Assigned: wisniewskit)

References

(Depends on 1 open bug)

Details

(Keywords: dev-doc-complete, Whiteboard: [downloads]triaged)

Attachments

(1 file)

It turns out that supporting estimatedEndTime is less tricky than supporting endTime, so I've split it out from bug 1256269 in the interest of getting it in as soon as possible.
Alright, the patch turned out to be easy to split off. Doing a try run here just in case: https://treeherder.mozilla.org/#/jobs?repo=try&revision=66caa06523ac9e6b6037154a0a67e898268a91ae
Alright, the try run seems fine. Andrew, you already reviewed this stuff in the other bug, so the review here is little more than a rubber-stamp. Let me know if you'd like another set of eyes on this, though!
Comment on attachment 8899180 [details]
Bug 1392003 - Support estimatedEndTime in DownloadItem;

https://reviewboard.mozilla.org/r/170452/#review175618

Thanks!

::: toolkit/components/extensions/test/xpcshell/test_ext_downloads_misc.js:884
(Diff revision 1)
> +  await waitForProgress(url, bytes => bytes > previousBytes);
> +
> +  msg = await runInExtension("search", {id});
> +  equal(msg.status, "success", "search() succeeded");
> +  equal(msg.result.length, 1, "search() found 1 download");
> +  ok(msg.result[0].estimatedEndTime, "download.estimatedEndTime is correct");

Can you add a comment indicating that we're not testing the calculation of this value, just that it is null/non-null at the right times?
Attachment #8899180 - Flags: review?(aswan) → review+
Good idea, done.

Requesting checkin.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1ba1737b4878
Support estimatedEndTime in DownloadItem; r=aswan
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1ba1737b4878
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Keywords: dev-doc-needed
Depends on: 1392270
I've documented this here: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/downloads/DownloadItem


Please let me know if this covers it.
Flags: needinfo?(wisniewskit)
Yes, that looks fine, thanks.
Flags: needinfo?(wisniewskit)
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe verify-“ flag.

Thanks!
Flags: needinfo?(wisniewskit)
Flags: qe-verify-
Thanks for setting the flag, Andrew.
Flags: needinfo?(wisniewskit)
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.