1392003 - Support estimatedEndTime in DownloadItem

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, enhancement, P5)

Description

[Thomas Wisniewski]

It turns out that supporting estimatedEndTime is less tricky than supporting endTime, so I've split it out from bug 1256269 in the interest of getting it in as soon as possible.

Comment 1

[Thomas Wisniewski]

Attachment: Bug 1392003 - Support estimatedEndTime in DownloadItem;

Review commit: https://reviewboard.mozilla.org/r/170452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170452/

Comment 2

[Thomas Wisniewski]

Alright, the patch turned out to be easy to split off. Doing a try run here just in case: https://treeherder.mozilla.org/#/jobs?repo=try&revision=66caa06523ac9e6b6037154a0a67e898268a91ae

Comment 3

[Thomas Wisniewski]

Alright, the try run seems fine. Andrew, you already reviewed this stuff in the other bug, so the review here is little more than a rubber-stamp. Let me know if you'd like another set of eyes on this, though!

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8899180 [details]
Bug 1392003 - Support estimatedEndTime in DownloadItem;

https://reviewboard.mozilla.org/r/170452/#review175618

Thanks!

::: toolkit/components/extensions/test/xpcshell/test_ext_downloads_misc.js:884
(Diff revision 1)
> +  await waitForProgress(url, bytes => bytes > previousBytes);
> +
> +  msg = await runInExtension("search", {id});
> +  equal(msg.status, "success", "search() succeeded");
> +  equal(msg.result.length, 1, "search() found 1 download");
> +  ok(msg.result[0].estimatedEndTime, "download.estimatedEndTime is correct");

Can you add a comment indicating that we're not testing the calculation of this value, just that it is null/non-null at the right times?

Comment 5

[Thomas Wisniewski]

Comment on attachment 8899180 [details]
Bug 1392003 - Support estimatedEndTime in DownloadItem;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170452/diff/1-2/

Comment 6

[Thomas Wisniewski]

Good idea, done.

Requesting checkin.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ba1737b4878
Support estimatedEndTime in DownloadItem; r=aswan

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1ba1737b4878

Comment 9

[Will Bamberg [:wbamberg]]

I've documented this here: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/downloads/DownloadItem


Please let me know if this covers it.

Comment 10

[Thomas Wisniewski]

Yes, that looks fine, thanks.

Comment 11

[CosminB]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe verify-“ flag.

Thanks!

Comment 12

[Thomas Wisniewski]

Thanks for setting the flag, Andrew.