1392095 - Update browser/components/sessionstore/test/browser_739531.js to comply with new data: URI inheritance model

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P1)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1392095_update_browser_739531.patch

I just realized that this test is failing occasionally when the pref is flipped by looking through a TRY push. This test has not shown up as failing on previous TRY runs. I guess the reason is that the test is very racy, because it simply relies on the fact that JS in the frame executes before executeSoon() on the main page fires. Anyway, this patch fixes at least the data: URI portion responsible for the failure.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ca5a6b268ccc2559cf5bf0246965631caf05e84&selectedJob=124395602

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b91870ea1243
Update browser/components/sessionstore/test/browser_739531.js to comply with new data: URI inheritance model. r=smaug

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing browser/components/sessionstore/test/browser_739531.js:

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e98af12b02f07c39c20598cdf98f35374bde76a

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=124502388&repo=mozilla-inbound
09:16:54     INFO -  383 INFO TEST-START | browser/components/sessionstore/test/browser_739531.js
09:16:54     INFO -  GECKO(2608) | ++DOCSHELL 29B2B000 == 133 [pid = 2608] [id = {71e4ae84-c9e0-44e1-b89d-c06e09ac1068}]
09:16:54     INFO -  GECKO(2608) | ++DOMWINDOW == 581 (29B2C400) [pid = 2608] [serial = 1954] [outer = 00000000]
09:16:54     INFO -  GECKO(2608) | ++DOMWINDOW == 582 (29D32800) [pid = 2608] [serial = 1955] [outer = 29B2C400]
09:16:54     INFO -  GECKO(2608) | [2608] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file z:/build/build/src/netwerk/base/nsChannelClassifier.cpp, line 320
09:16:55     INFO -  GECKO(2608) | ++DOMWINDOW == 583 (26E13000) [pid = 2608] [serial = 1956] [outer = 29B2C400]
09:16:55     INFO -  GECKO(2608) | [2608] WARNING: We've already scheduled a task for background list flush.: file z:/build/build/src/parser/html/nsHtml5TreeOpExecutor.cpp, line 288
09:16:55     INFO -  GECKO(2608) | ++DOCSHELL 268E4C00 == 134 [pid = 2608] [id = {f0d0fe84-dd68-430c-94d8-3e1d7ae8b34d}]
09:16:55     INFO -  GECKO(2608) | ++DOMWINDOW == 584 (26E11C00) [pid = 2608] [serial = 1957] [outer = 00000000]
09:16:55     INFO -  GECKO(2608) | ++DOMWINDOW == 585 (28416000) [pid = 2608] [serial = 1958] [outer = 26E11C00]
09:16:55     INFO -  TEST-INFO | started process screenshot
09:16:55     INFO -  TEST-INFO | screenshot: exit 0
09:16:55    ERROR -  384 INFO TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_739531.js | uncaught exception - TypeError: Argument 1 of Document.adoptNode does not implement interface Node. at boom@http://mochi.test:8888/browser/browser/components/sessionstore/test/browser_739531_sample.html:16:3
09:16:55     INFO -  onload@http://mochi.test:8888/browser/browser/components/sessionstore/test/browser_739531_sample.html:1:1
09:16:55     INFO -  Stack trace:
09:16:55     INFO -  chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1652

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1392095_update_browser_739531.patch

The problem is that SimplePowers.wrap does not forward all the APIs, like in this case. In that case we have to go back and load the frame data from an external file like we did in other cases. 

I tested locally by commenting code within the main test file to make sure boom() executes before the onload fires. Works now.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd7a7759990a
Update browser/components/sessionstore/test/browser_739531.js to comply with new data: URI inheritance model. r=smaug

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fd7a7759990a