1392151 - ActivityStream: don't ask for password for thumbnails

Status: RESOLVED INVALID

(Firefox :: New Tab Page, defect)

Description

[Olivier Mehani]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170814073321

Steps to reproduce:

Regularly access an HTTP Basic Auth protected site, which made it show up in the Top sites.

Restart Firefox, and open a new tab.


Actual results:

When opening the new tab, the Activity Stream is displayed (good), including an entry for the password-protected site (good), with a thumbnail from the previous visit (good).

It then pops up a standard password Basic Auth password request modal dialog (bad).


Expected results:

When opening the new tab, the Activity Stream should be displayed (tick), including an entry for the password-protected site (tick), with a thumbnail from the previous visit (tick).

Upon receiving a 401, Activity Stream should give up on trying to refresh the thumbnail, and just display the old one (as it already does) rather than asking the user for the password.

Comment 1

[Ed Lee :Mardak]

Olivier, are you using the Activity Stream add-on (potentially from test pilot) or did you set "browser.newtabpage.activity-stream.enabled" pref as it's off by default in Firefox 55.

Comment 2

[Ed Lee :Mardak]

I just tested with https://jigsaw.w3.org/HTTP/Basic/ as a pinned site, and a thumbnail/screenshot is created without logging in. This must have been a test pilot add-on version issue and not with the one from browser.newtabpage.activity-stream.enabled.

Comment 3

[Ed Lee :Mardak]

Attachment: Screen Shot 2017-08-30 at 7.46.17 PM.png

Comment 4

[Olivier Mehani]

Ah, yes, that was a TestPilot Addon. I now have disabled it, and enabled browser.newtabpage.activity-stream.enabled (FF 55.0.3), but I now get a blank page rather than the activity stream, so I can't check. I must have broken something else in the process...

Comment 5

[Ed Lee :Mardak]

I don't think it's working on 55. You'll need to wait or update to 56.