1392153 - Add margin between fxa name & email and manage account shouldn't open new window

Status: VERIFIED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Ricky Chien [:rickychien] (inactive)]

Attachment: display&email.png

See attachment. If the optional display name is shown, then we should have a margin between display name and email address to distinct them.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Another small issue will be fixed within this patch as well.

Clicking "Manage account" link as attachment displayed, we should just redirect current tab's url to new Firefox Account Management site instead of opening a new Firefox window.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1392153 - Display fxa name & email properly and manage account shouldn't open new window

Review commit: https://reviewboard.mozilla.org/r/170726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170726/

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Current implementation has followed the visual spec to fix the uncovered display name in Fxa page. Helen will update the visual spec soon.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8899447 [details]
Bug 1392153 - Display fxa name & email properly and manage account shouldn't open new window

https://reviewboard.mozilla.org/r/170726/#review175958

::: browser/themes/shared/incontentprefs/preferences.inc.css:572
(Diff revision 1)
>  #fxaEmailAddress1,
>  #fxaEmailAddress2,
>  #fxaEmailAddress3 {

Can you please file a bug to change these from IDs to classes? We can use querySelector to find the correct email address element when needed.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8899447 [details]
Bug 1392153 - Display fxa name & email properly and manage account shouldn't open new window

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170726/diff/1-2/

Comment 6

[Ricky Chien [:rickychien] (inactive)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> Comment on attachment 8899447 [details]
> Bug 1392153 - Display fxa name & email properly and manage account shouldn't
> open new window
> 
> https://reviewboard.mozilla.org/r/170726/#review175958
> 
> ::: browser/themes/shared/incontentprefs/preferences.inc.css:572
> (Diff revision 1)
> >  #fxaEmailAddress1,
> >  #fxaEmailAddress2,
> >  #fxaEmailAddress3 {
> 
> Can you please file a bug to change these from IDs to classes? We can use
> querySelector to find the correct email address element when needed.

I've updated those IDs to classes and use querySelector in latest update patch. thanks

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8899447 [details]
Bug 1392153 - Display fxa name & email properly and manage account shouldn't open new window

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170726/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79a0409a6df7
Display fxa name & email properly and manage account shouldn't open new window r=jaws

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/79a0409a6df7

Comment 10

[roxleitan]

Verified as fixed using the latest Nightly 57.0a1 (2017-08-25) on Ubuntu 16.04, Mac OS X 10.12 and Windows 10 x64.