Add margin between fxa name & email and manage account shouldn't open new window

VERIFIED FIXED in Firefox 57

Status

()

P1
normal
VERIFIED FIXED
a year ago
11 months ago

People

(Reporter: rickychien, Assigned: rickychien)

Tracking

(Blocks: 1 bug)

55 Branch
Firefox 57
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox57 verified)

Details

(Whiteboard: [photon-preference], URL)

Attachments

(2 attachments)

Created attachment 8899310 [details]
display&email.png

See attachment. If the optional display name is shown, then we should have a margin between display name and email address to distinct them.
Another small issue will be fixed within this patch as well.

Clicking "Manage account" link as attachment displayed, we should just redirect current tab's url to new Firefox Account Management site instead of opening a new Firefox window.
Summary: Add a margin between about:preferences#sync's display name & email address → Add margin between fxa name & email and manage account shouldn't open new window
Comment hidden (mozreview-request)
Current implementation has followed the visual spec to fix the uncovered display name in Fxa page. Helen will update the visual spec soon.

Comment 4

a year ago
mozreview-review
Comment on attachment 8899447 [details]
Bug 1392153 - Display fxa name & email properly and manage account shouldn't open new window

https://reviewboard.mozilla.org/r/170726/#review175958

::: browser/themes/shared/incontentprefs/preferences.inc.css:572
(Diff revision 1)
>  #fxaEmailAddress1,
>  #fxaEmailAddress2,
>  #fxaEmailAddress3 {

Can you please file a bug to change these from IDs to classes? We can use querySelector to find the correct email address element when needed.
Attachment #8899447 - Flags: review?(jaws) → review+

Updated

a year ago
Flags: qe-verify+
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage] → [photon-preference]
Comment hidden (mozreview-request)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> Comment on attachment 8899447 [details]
> Bug 1392153 - Display fxa name & email properly and manage account shouldn't
> open new window
> 
> https://reviewboard.mozilla.org/r/170726/#review175958
> 
> ::: browser/themes/shared/incontentprefs/preferences.inc.css:572
> (Diff revision 1)
> >  #fxaEmailAddress1,
> >  #fxaEmailAddress2,
> >  #fxaEmailAddress3 {
> 
> Can you please file a bug to change these from IDs to classes? We can use
> querySelector to find the correct email address element when needed.

I've updated those IDs to classes and use querySelector in latest update patch. thanks
Comment hidden (mozreview-request)

Comment 8

a year ago
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79a0409a6df7
Display fxa name & email properly and manage account shouldn't open new window r=jaws
https://hg.mozilla.org/mozilla-central/rev/79a0409a6df7
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Verified as fixed using the latest Nightly 57.0a1 (2017-08-25) on Ubuntu 16.04, Mac OS X 10.12 and Windows 10 x64.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Flags: qe-verify+

Updated

a year ago
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.