1392224 - Make Fennec the default handler for Leanplum Push Notification

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Metrics, enhancement)

Description

[Nevin Chen(Not active on Bugzilla)]

We have two ways to let fennec be the default handler for Push Notification.
1. Through intent string in Leanplum backend
 => This don't need to change Leanplum SDK, but will need a lot of maintanace effort for Leaplum setup. And Leanplum SDK has bug in it since queryIntentActivities() may sometimes return null list. Thus make no activity can handle the action_vew intent.

2. Through the code we handle deep link
We can avoid above problems but need to manually upstream the SDK( and we already did).

The long term fix maybe submit a PR to Leanplum and see if we can use resolveActivity() instead. But for now I want to make it as simple as possible.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1392224 - Make Fennec the default handler for Leanplum Push Notification.

Review commit: https://reviewboard.mozilla.org/r/170696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170696/

Comment 2

[Max Liu [:maliu]]

Comment on attachment 8899422 [details]
Bug 1392224 - Make Fennec the default handler for Leanplum Push Notification.

https://reviewboard.mozilla.org/r/170696/#review176140

Comment 3

[Max Liu [:maliu]]

Comment on attachment 8899422 [details]
Bug 1392224 - Make Fennec the default handler for Leanplum Push Notification.

https://reviewboard.mozilla.org/r/170696/#review176150

::: mobile/android/thirdparty/com/leanplum/LeanplumPushService.java:444
(Diff revision 1)
>      String action = notification.getString(Keys.PUSH_MESSAGE_ACTION);
>      if (action != null && action.contains(OPEN_URL)) {
>        Intent deepLinkIntent = getDeepLinkIntent(notification);
> -      if (deepLinkIntent != null && activityHasIntent(context, deepLinkIntent)) {
> +      if (deepLinkIntent != null) {
> +        // if it's a deep link, always use Fennec to start it
> +        deepLinkIntent.setPackage(context.getPackageName());

What's the difference between this line and inside activityHasIntent?

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8899422 [details]
Bug 1392224 - Make Fennec the default handler for Leanplum Push Notification.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170696/diff/1-2/

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8899422 [details]
Bug 1392224 - Make Fennec the default handler for Leanplum Push Notification.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170696/diff/2-3/

Comment 6

[Max Liu [:maliu]]

Comment on attachment 8899422 [details]
Bug 1392224 - Make Fennec the default handler for Leanplum Push Notification.

https://reviewboard.mozilla.org/r/170696/#review176578

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fa4d82e8c09
Make Fennec the default handler for Leanplum Push Notification. r=maliu

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7fa4d82e8c09